Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Xcode dependencies to Mac hello_world_macos__compile #110274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

Add Xcode dependencies to Mac hello_world_macos__compile #110274

merged 1 commit into from
Aug 25, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Aug 25, 2022 •
edited
Loading

Fixes #110277

Yesterday, #110090 landed and brought up hello_world_macos__compile benchmark tests. Those tests ran successfully, locally because Xcode was installed. Running in the devicelab causes the test to fail due to a missing Xcode dependency in .ci.yaml.
...

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@a-wallen a-wallen force-pushed the macos_bringup_hello_compile branch from 531df2d to 6b65f26 Compare August 25, 2022 17:05
@a-wallen a-wallen changed the title Remove bringup to test dependencies Add Xcode dependencies to Mac hello_world_macos__compile Aug 25, 2022
@a-wallen a-wallen requested a review from CaseyHillers August 25, 2022 17:51
@a-wallen a-wallen marked this pull request as ready for review August 25, 2022 17:51
@a-wallen a-wallen requested a review from keyonghan as a code owner August 25, 2022 17:51
keyonghan
keyonghan reviewed Aug 25, 2022
View reviewed changes
.ci.yaml Outdated
@@ -2522,10 +2522,13 @@ targets:
- .ci.yaml

- name: Mac hello_world_macos__compile
bringup: true # New target https://github.com/flutter/flutter/issues/109633
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this before the test gets validated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-oh. Good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @keyonghan

@a-wallen a-wallen force-pushed the macos_bringup_hello_compile branch from 6b65f26 to 4d426e8 Compare August 25, 2022 19:32
yaakovschectman
yaakovschectman approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keyonghan
keyonghan approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@auto-submit auto-submit bot merged commit 5705890 into flutter:master Aug 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
22b82a4 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
863b5fc 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
a5b0f75 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
00f9b1e 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
7c548a1 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
af1db35 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
6643615 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
ecb24c2 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
8fb02a6 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
e2cd213 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
f6a29fe 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
c95fe9e 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
d8b63fb 
…lutter/flutter#110274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
a1bb623 
…lutter/flutter#110274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2022
@engine-flutter-autoroll
5705890 Add Xcode dependencies to Mac hello_world_macos__compile (f…
53df345 
…lutter/flutter#110274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Bring up) hello_world_macos__compile task fails without xcode.
3 participants
@a-wallen @keyonghan @yaakovschectman