Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[macOS] Bring up "flutter_gallery" devicelab, start up test for x86. #110370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2022

Conversation

a-wallen
Copy link
Contributor

Reason

The initial desktop integration tests are running now, but they need to be expanded beyond the initial gallery build test; filing this to make sure that planned work is captured in the issue tracker. This should be much more straightforward that getting the first one running was, since the bot work is all complete.

In particular we should ensure we are testing building a freshly created project to catch errors in template changes. (I haven't checked where that test lives on existing platforms; it may be a device lab test, which still needs desktop bring-up).

Related

fixes #110084

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 26, 2022
@a-wallen a-wallen marked this pull request as ready for review August 26, 2022 20:21
@a-wallen a-wallen requested a review from keyonghan as a code owner August 26, 2022 20:21
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2022
@auto-submit auto-submit bot merged commit 4770e34 into flutter:master Aug 26, 2022
jmagman added a commit that referenced this pull request Aug 26, 2022
@jmagman
Copy link
Member

jmagman commented Aug 26, 2022

This broke the tree: #110372.
Please wait for approval from codeowners before merging.

christopherfujino pushed a commit that referenced this pull request Aug 26, 2022
Comment on lines -9 to -10
// It's intended to use the Gallery startup test as a smoke test on macOS
// Catalina.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev/devicelab/bin/tasks/flutter_gallery_mac__start_up.dart test was for Android Mac_android flutter_gallery_mac__start_up. The rename to flutter_gallery_macos__start_up.dart broke that test.

flutter/.ci.yaml

Line 3084 in 4770e34

task_name: flutter_gallery_mac__start_up

@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 26, 2022

Looks like we didn't need this, since Mac_android flutter_gallery_mac__start_up already covers it whoops, never mind. It looks like you should have copy pasted to a new task instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Bring up "flutter_gallery" devicelab, startup tests for x86.
4 participants