Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[macOS] Add platform_view example. #111005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 7, 2022
Merged

[macOS] Add platform_view example. #111005

merged 13 commits into from
Sep 7, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 5, 2022 •
edited
Loading

Adds an implementation for platform_view on macOS for better example coverage and for device lab tests.

Screen.Recording.2022-09-05.at.11.10.40.AM.mov

Issues #111004

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 5, 2022
@a-wallen a-wallen mentioned this pull request Sep 5, 2022
Closed
8 tasks
@a-wallen a-wallen force-pushed the macos_platform_view_example branch from b7de5ae to 705dd7d Compare September 6, 2022 17:28
@a-wallen a-wallen marked this pull request as ready for review September 6, 2022 17:45
yaakovschectman
yaakovschectman approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loic-sharma
loic-sharma approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me but consider getting approval from someone that's more familiar with macOS!

@a-wallen a-wallen requested a review from jmagman September 6, 2022 19:16
@a-wallen a-wallen mentioned this pull request Sep 6, 2022
Merged
8 tasks
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2022
@auto-submit auto-submit bot merged commit c5890f0 into flutter:master Sep 7, 2022
cbracken
cbracken reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit!

examples/platform_view/macos/Runner/PlatformViewController.swift

import Cocoa

class PlatformViewController: NSViewController {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a doc comment, especially since it's an example.

@a-wallen a-wallen mentioned this pull request Sep 7, 2022
Closed
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
c5890f0 [macOS] Add platform_view example. (flutter/flutter#111005)
0b70efe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
c5890f0 [macOS] Add platform_view example. (flutter/flutter#111005)
0b0a659
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
c5890f0 [macOS] Add platform_view example. (flutter/flutter#111005)
af7c480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken left review comments

@jmagman jmagman jmagman approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a-wallen @cbracken @jmagman @loic-sharma @yaakovschectman