Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix an reorderable list animation issue:"Reversed ReorderableListView drop animation moves item one row higher than it should #110949" #111027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2022
Merged

Fix an reorderable list animation issue:"Reversed ReorderableListView drop animation moves item one row higher than it should #110949" #111027

merged 6 commits into from
Sep 20, 2022

Conversation

hannah-hyj
Copy link
Member

fixed:#110949

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • [] I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 6, 2022
@hannah-hyj hannah-hyj changed the title Fix an reorderable list animation issue Fix an reorderable list animation issue:"Reversed ReorderableListView drop animation moves item one row higher than it should #110949" Sep 6, 2022
@hannah-hyj
Copy link
Member Author

bump for review

darrenaustin
darrenaustin approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice fix.

Just a couple of formatting nits to fix. Thx.

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit auto-submit bot merged commit d5bee36 into flutter:master Sep 20, 2022
This was referenced Sep 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
d5bee36 Fix an reorderable list animation issue:"Reversed Reorderable…
b455a28 
…ListView drop animation moves item one row higher than it should #110949" (flutter/flutter#111027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 20, 2022
@engine-flutter-autoroll
d5bee36 Fix an reorderable list animation issue:"Reversed Reorderable…
c338a94 
…ListView drop animation moves item one row higher than it should #110949" (flutter/flutter#111027)
@skazkiful skazkiful mentioned this pull request Nov 18, 2022
Closed
@TahaTesser TahaTesser mentioned this pull request Aug 8, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannah-hyj @darrenaustin