Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Fonts] Update icons #111092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 7, 2022
Merged

[Fonts] Update icons #111092

merged 7 commits into from
Sep 7, 2022

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Sep 7, 2022

Screen Shot 2022-09-07 at 16 28 14

Adds 130 new icons. Removes 4 no longer available icons (Whatsapp + its variants).

Fixes #103202 (previous attempt #108858 was reverted in #109073)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 7, 2022
@guidezpl guidezpl marked this pull request as ready for review September 7, 2022 15:32
@guidezpl guidezpl requested a review from esouthren September 7, 2022 15:32
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #111092 at sha 2745ba4

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Sep 7, 2022
@KTBsomen
Copy link

KTBsomen commented Feb 4, 2025

I hope this can help someone in the future,

https://web.whatsapp.com/favicon-64x64.ico

Image.network("https://web.whatsapp.com/favicon-64x64.ico",
                                  height: 28,
                                  width: 28),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons.repeat_on renders as a black square
3 participants