Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Delete flutter_gallery_mac__start_up. #111147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2022
Merged

Delete flutter_gallery_mac__start_up. #111147

merged 1 commit into from
Sep 8, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 7, 2022 •
edited
Loading

Following up on a list of action items that stemmed from #110379.

The device lab test flutter_gallery_mac__start_up was no longer important and can now be deleted. First the target needed to be removed (#111117) and then the task runner could be removed (this).

Fixes #111143

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 7, 2022
keyonghan
keyonghan approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-wallen a-wallen marked this pull request as ready for review September 7, 2022 23:59
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2022
@auto-submit auto-submit bot merged commit 9a4e4bd into flutter:master Sep 8, 2022
@a-wallen a-wallen deleted the remove_flutter_gallery_mac__start_up branch September 8, 2022 00:00
@a-wallen a-wallen mentioned this pull request Sep 8, 2022
Merged
8 tasks
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
9a4e4bd Delete flutter_gallery_mac__start_up. (flutter/flutter#111147)
8adeaf4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
9a4e4bd Delete flutter_gallery_mac__start_up. (flutter/flutter#111147)
40f6b49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
9a4e4bd Delete flutter_gallery_mac__start_up. (flutter/flutter#111147)
dfbb38d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove flutter_gallery_mac__start_up.
3 participants
@a-wallen @jmagman @keyonghan