Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Deprecate ThemeDate.bottomAppBarColor" #111210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Deprecate ThemeDate.bottomAppBarColor" #111210

wants to merge 1 commit into from

Conversation

XilaiZhang
Copy link
Contributor

Reverts #111080 to revert #110162 afterwards. There is a conflict to solely revert #110162.

Context: it is possible that #110162 resulted in some scuba differences in google tests.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Sep 8, 2022
@CaseyHillers
Copy link
Contributor

Instead of reverting #111080, can we manually deal with the merge conflicts when reverting #110162?

Otherwise, this PR should contain both PRs necessary for the revert to go through.

@XilaiZhang
Copy link
Contributor Author

will close this PR as the diff in scuba has been identified as expected.

@XilaiZhang XilaiZhang closed this Sep 8, 2022
@guidezpl guidezpl deleted the revert-111080-bottomappbarcolor branch April 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@guidezpl guidezpl Awaiting requested review from guidezpl

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XilaiZhang @CaseyHillers