Fix Magnifier crash #111303
Merged
Fix Magnifier crash #111303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -861,7 +861,7 @@ class SelectionOverlay { | |||
| context: context, | |||
| below: magnifierConfiguration.shouldDisplayHandlesInMagnifier | |||
| ? null | |||
| : _handles!.first, | |||
There was a problem hiding this comment.
Should the || _handles == null above on line 856 be removed?
There was a problem hiding this comment.
Yes thank you! I think you added that check just before I created this PR and I somehow totally missed it. Likely your PR has already fixed the crash that I was trying to fix with this PR. I think this PR is still worthwhile to allow the magnifier to show without the handles being visible though. Let me know what you think of the code now after my change.
There was a problem hiding this comment.
Yeah I added that check, and I agree this is still a worthwhile change.
| @@ -1279,6 +1281,28 @@ void main() { | |||
| await tester.pump(const Duration(milliseconds: 20)); | |||
| expect(endDragEndDetails, isNotNull); | |||
| }); | |||
|
|
|||
| testWidgets('can show magnifier when no handles exist', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
Should we also, at the end of this test, confirm the magnifier is showing?
This was referenced Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that was happening when the magnifier was shown and no handles were visible.
Fixes #111301