Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add documentation for platform_view example. #111623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2022
Merged

Add documentation for platform_view example. #111623

merged 2 commits into from
Sep 15, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 15, 2022 •
edited
Loading

When platform_view first landed for macOS there was no documentation for any of the classes added. This PR adds documentation for the MainFlutterWindow and the PlatformViewController classes.

fixes #111142

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].

Tree Hygiene page: only affect comments (including documentation).

  • All existing and new tests are passing.

@a-wallen a-wallen requested a review from cbracken September 15, 2022 00:41
@flutter-dashboard flutter-dashboard bot added the d: examples Sample code and demos label Sep 15, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 15, 2022
@a-wallen
Copy link
Contributor Author

Dear auto-submit bot,

Please read my PR and see that it only affects comments.

Thanks!
Alex

@a-wallen a-wallen mentioned this pull request Sep 15, 2022
Closed
cbracken
cbracken approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments!

@a-wallen a-wallen force-pushed the platform_view_macos_documentation branch from ec25002 to 6459db3 Compare September 15, 2022 19:43
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2022
@auto-submit auto-submit bot merged commit 10f088e into flutter:master Sep 15, 2022
This was referenced Sep 16, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
a50b298 
…er#111623)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
ce94cf8 
…er#111623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
cbe8423 
…er#111623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
2e1009c 
…er#111623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
ea0a219 
…er#111623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
cb26098 
…er#111623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
b89d2fd 
…er#111623)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 16, 2022
@engine-flutter-autoroll
10f088e Add documentation for platform_view example. (flutter/flutt…
69ecc24 
…er#111623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation to macOS platform_view example.
2 participants
@a-wallen @cbracken