Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Android] Fix spell_check integration test flakiness #112109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 4, 2022
Merged

[Android] Fix spell_check integration test flakiness #112109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b436a44
Change pump
camsim99 Sep 21, 2022
16773b7
Add modified waitFor
camsim99 Sep 30, 2022
e3bfa15
Clean
camsim99 Sep 30, 2022
593574b
Merge remote-tracking branch 'upstream/master' into sc_flake
camsim99 Sep 30, 2022
2074fd7
Cleanup
camsim99 Oct 3, 2022
abac60c
Remove space
camsim99 Oct 4, 2022
76f811f
Fix extra "the" in doc comment
justinmc Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2107,7 +2107,7 @@ targets:
task_name: routing_test

- name: Linux_android spell_check_test
bringup: true
bringup: true # TESTING PURPOSES ONLY
recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60
Expand Down
55 changes: 34 additions & 21 deletions dev/integration_tests/spell_check/integration_test/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,35 @@ import 'package:spell_check/main.dart';
late DefaultSpellCheckService defaultSpellCheckService;
late Locale locale;

/// Copy from flutter/test/widgets/editable_text_utils.dart.
RenderEditable findRenderEditable(WidgetTester tester, Type type) {
final RenderObject root = tester.renderObject(find.byType(type));
/// Waits to find [EditableText] that displays text with misspelled
/// words marked the same as the [TextSpan] provided and returns
/// true if it is found before timing out at 20 seconds.
Future<bool> findTextSpanTree(
WidgetTester tester,
TextSpan inlineSpan,
) async {
final RenderObject root = tester.renderObject(find.byType(EditableText));
expect(root, isNotNull);

late RenderEditable renderEditable;
RenderEditable? renderEditable;
void recursiveFinder(RenderObject child) {
if (child is RenderEditable) {
if (child is RenderEditable && child.text == inlineSpan) {
renderEditable = child;
return;
}
child.visitChildren(recursiveFinder);
}
root.visitChildren(recursiveFinder);
expect(renderEditable, isNotNull);
return renderEditable;

final DateTime endTime = tester.binding.clock.now().add(const Duration(seconds: 20));
do {
if (tester.binding.clock.now().isAfter(endTime)) {
return false;
}
await tester.pump(const Duration(seconds: 1));
root.visitChildren(recursiveFinder);
} while (renderEditable == null);

return true;
}

Future<void> main() async {
Expand Down Expand Up @@ -147,21 +160,21 @@ Future<void> main() async {

await tester.pumpWidget(const MyApp());

await tester.enterText(find.byType(EditableText), 'Hey cfabiueqqocnakoef! Hey!');
await tester.pumpAndSettle();

final RenderEditable renderEditable = findRenderEditable(tester, EditableText);
final TextSpan textSpanTree = renderEditable.text! as TextSpan;
await tester.enterText(find.byType(EditableText), 'Hey cfabiueq qocnakoef! Hey!');

const TextSpan expectedTextSpanTree = TextSpan(
style: style,
children: <TextSpan>[
TextSpan(style: style, text: 'Hey '),
TextSpan(style: misspelledTextStyle, text: 'cfabiueqqocnakoef'),
TextSpan(style: style, text: '! Hey!'),
]);

expect(textSpanTree, equals(expectedTextSpanTree));
style: style,
children: <TextSpan>[
TextSpan(style: style, text: 'Hey '),
TextSpan(style: misspelledTextStyle, text: 'cfabiueq'),
TextSpan(style: style, text: ' '),
TextSpan(style: misspelledTextStyle, text: 'qocnakoef'),
TextSpan(style: style, text: '! Hey!'),
]);

final bool expectedTextSpanTreeFound = await findTextSpanTree(tester, expectedTextSpanTree);

expect(expectedTextSpanTreeFound, isTrue);
});

test(
Expand Down