Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[web] Fix kIsWeb for Dart2wasm. #112122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

[web] Fix kIsWeb for Dart2wasm. #112122

merged 2 commits into from
Oct 4, 2022

Conversation

joshualitt
Copy link
Contributor

No description provided.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 21, 2022
@joshualitt joshualitt force-pushed the upstream-2 branch 2 times, most recently from 92e1f38 to cc03c29 Compare September 21, 2022 23:08
jonahwilliams
jonahwilliams approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest in peace, my hacky friend.

LGTM

@justinmc justinmc requested review from justinmc and removed request for justinmc September 22, 2022 21:53
justinmc
justinmc approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm somehow sad to see this go!

@joshualitt
Copy link
Contributor Author

Just a heads up, this CL is waiting for an analyzer roll, and will probably fail until those changes land.

@ueman ueman mentioned this pull request Sep 29, 2022
Closed
@joshualitt joshualitt merged commit 07c5ebc into flutter:master Oct 4, 2022
This was referenced Oct 5, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
07c5ebc [web] Fix kIsWeb for Dart2wasm. (flutter/flutter#112122)
0c43cac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
07c5ebc [web] Fix kIsWeb for Dart2wasm. (flutter/flutter#112122)
c087b51
This was referenced Oct 5, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
07c5ebc [web] Fix kIsWeb for Dart2wasm. (flutter/flutter#112122)
d70b1cc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
07c5ebc [web] Fix kIsWeb for Dart2wasm. (flutter/flutter#112122)
d513d7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshualitt @justinmc @jonahwilliams