Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Roll Flutter Engine from 9692f09afd67 to cbb96d0b06d7 (2 revisions)" #112905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Oct 5, 2022

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine repository. See also e: labels. label Oct 5, 2022
@zanderso zanderso added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 5, 2022
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 5, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 5, 2022

revert label is removed for flutter/flutter, pr#: 112905, Failed to merge pr#: 112905 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Required status check "ci.yaml validation" is queued., locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)]).

@zanderso
Copy link
Member Author

zanderso commented Oct 5, 2022

@keyonghan for revert tag failure

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. revert Autorevert PR (with "Reason for revert:" comment) labels Oct 5, 2022
@auto-submit auto-submit bot merged commit 28da871 into master Oct 5, 2022
@auto-submit auto-submit bot deleted the revert-112883-flutter-engine-flutter-autoroll-76ddb96c-fdab-4cf1-a042-c0b86b3b316b-1664917915 branch October 5, 2022 03:17
@keyonghan
Copy link
Contributor

@keyonghan for revert tag failure

@ricardoamador Have we added retry for graphqlErrors error?

@ricardoamador
Copy link
Contributor

Odd. Let me take a look.

@ricardoamador
Copy link
Contributor

ricardoamador commented Oct 5, 2022

It is odd that the required check is from graphql. That should not matter. Keyong, yes the graphql error is retryable. That is the one we are looking for.

@ricardoamador
Copy link
Contributor

Ah okay so there is no conflict between labels but I am looking into why that check was considered required when the revert label was present. The bot did merge the pull request after Zach readded the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. revert Autorevert PR (with "Reason for revert:" comment) warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants