-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Revert "Roll Flutter Engine from 9692f09afd67 to cbb96d0b06d7 (2 revisions)" #112905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Roll Flutter Engine from 9692f09afd67 to cbb96d0b06d7 (2 revisions)" #112905
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
revert label is removed for flutter/flutter, pr#: 112905, Failed to merge pr#: 112905 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Required status check "ci.yaml validation" is queued., locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)]). |
@keyonghan for revert tag failure |
@ricardoamador Have we added retry for |
Odd. Let me take a look. |
It is odd that the required check is from graphql. That should not matter. Keyong, yes the graphql error is retryable. That is the one we are looking for. |
Ah okay so there is no conflict between labels but I am looking into why that check was considered required when the revert label was present. The bot did merge the pull request after Zach readded the label. |
Reverts #112883
Reverting for the failures in https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20platform_channel_sample_test_windows/1804/overview