Dependency injection Attach command #113227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| required ProcessInfo processInfo, | ||
| required FileSystem fileSystem, | ||
| }): _artifacts = artifacts, | ||
| _hotRunnerFactory = (hotRunnerFactory == null) ? HotRunnerFactory() : hotRunnerFactory, |
There was a problem hiding this comment.
Suggested change
| _hotRunnerFactory = (hotRunnerFactory == null) ? HotRunnerFactory() : hotRunnerFactory, | |
| _hotRunnerFactory = hotRunnerFactory ?? HotRunnerFactory(), |
| @@ -316,7 +345,7 @@ known, it can be explicitly provided to attach via the command-line, e.g. | |||
| ).asBroadcastStream(); | |||
| } | |||
|
|
|||
| globals.terminal.usesTerminalUi = daemon == null; | |||
| _terminal.usesTerminalUi = daemon == null; | |||
There was a problem hiding this comment.
Seems strange to me that we set this here; I would think that we would do it somewhere earlier. I'm just talking out loud though, keeping status quo LGTM for now.
christopherfujino
approved these changes
Oct 17, 2022
|
Thanks for migrating this command! |
| @@ -438,7 +564,16 @@ void main() { | |||
| }); | |||
|
|
|||
| testUsingContext('exits when multiple devices connected', () async { | |||
| final AttachCommand command = AttachCommand(); | |||
| final AttachCommand command = AttachCommand( | |||
There was a problem hiding this comment.
Oh btw, are we still relying on all the overrides here? I would have hoped we could use testWithoutContext after this refactor.
There was a problem hiding this comment.
I just tried using testWithoutContext but it seems like the attach command and the BufferLogger used in this tests still needs a context
There was a problem hiding this comment.
Annoyingly FlutterCommand depends on globals :(
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #107607
Pre-launch Checklist
///).