Show Xcode compilation errors at end of build, suppress stdout and stderr from Xcode #113302
Conversation
| } | ||
| if (!allowFail && result.exitCode != 0) { | ||
| stderr.write('${result.stderr}\n'); |
There was a problem hiding this comment.
This was redundant, echoError writes to stderr right above this.
| @@ -414,14 +414,6 @@ Future<XcodeBuildResult> buildXcodeProject({ | |||
| } | |||
| if (buildResult != null && buildResult.exitCode != 0) { | |||
| globals.printStatus('Failed to build iOS app'); | |||
| if (buildResult.stderr.isNotEmpty) { | |||
There was a problem hiding this comment.
Stop printing the Xcode output when we have more specific error to display, to reduce noise
There was a problem hiding this comment.
So the assumption is that the actual error was already echo'd by xcode_backend?
There was a problem hiding this comment.
Yes, that because the build failed there will be at least one error message from Xcode that will be parsed and already shown. That includes any failure from assemble, including a dart compilation issue.
| @@ -265,49 +266,48 @@ Xcode's output: | |||
| ↳ | |||
| blah | |||
|
|
|||
| === CLEAN TARGET url_launcher OF PROJECT Pods WITH CONFIGURATION Release === | |||
There was a problem hiding this comment.
Removed some of the irrelevant parts of the output of these tests to make it more concise.
| if (resultStderr.isNotEmpty) { | ||
| final StringBuffer errorOutput = StringBuffer(); | ||
| if (result.exitCode != 0) { | ||
| // "error:" prefix makes this show up as an Xcode compilation error. |
There was a problem hiding this comment.
Nifty and totally undocumented, I don't even remember how I learned about this.
| @@ -782,11 +774,21 @@ bool _needUpdateSigningIdentifier(XcodeBuildExecution? xcodeBuildExecution) { | |||
| // | |||
| // As detecting issues in stdout is not usually accurate, this should be used as a fallback when other issue detecting methods failed. | |||
| void _parseIssueInStdout(XcodeBuildExecution xcodeBuildExecution, Logger logger, XcodeBuildResult result) { | |||
| final String? stderr = result.stderr; | |||
| if (stderr != null && stderr.isNotEmpty) { | |||
| logger.printStatus('Error output from Xcode build:\n↳'); | |||
There was a problem hiding this comment.
should this be logger.printError?
There was a problem hiding this comment.
This was just moved, and it was printStatus before. Not sure why and I don't really want to change it now... Hopefully we almost never drop back to this fallback.
…t and stderr from Xcode (flutter/flutter#113302)
…t and stderr from Xcode (flutter/flutter#113302)
…t and stderr from Xcode (flutter/flutter#113302)
…t and stderr from Xcode (flutter/flutter#113302)
assemblestderr witherror:to make them show up as compilation errors in the Xcode UI and the parsed XCResults. Example dart compilation error showing in Xcode:Treat
assemblebuild system exceptions as fatal, but only show stack traces in verbose mode. As far as I can tell noExceptionMeasurementwas ever fatal, so only showing stack traces in verbose mode shouldn't suppress previously displayed stack traces, since there were none. See Don't log stack traces to console on build failures #44966 and [flutter_tools] Allow the tool to suppress compilation errors. #58539 for some of the history of that TODO.Stop showing the final x stderr and stdout lines of the Xcode build, unless the xcresult can't be parsed. This should reduce the noise in the build failure.
Stop showing the "missing development team" message when there is a more specific error to show.
This should make triaging issues easier, since the build error will be visible and obvious without
--verbose.Iteration on #22536
Fixes #32755
Fixes #113203
Fixes #100721
Fixes #98298
Compilation failure on iOS
Before
After
Other assemble failure on iOS
A file system exception
Before
No indication there is a file system issue.
After
Compilation failure on Android
Before
After
There's one additional line:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.