Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[docs] Refresh dev/bots/README.md #113464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2022
Merged

[docs] Refresh dev/bots/README.md #113464

merged 2 commits into from
Oct 19, 2022

Conversation

CaseyHillers
Copy link
Contributor

  • Remove old references to luci configs and chrome recipes

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

[docs] Refresh dev/bots/README.md
feb9ab9 
* Remove old references to luci configs and chrome recipes
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 14, 2022
keyonghan
keyonghan approved these changes Oct 19, 2022
View reviewed changes
dev/bots/README.md Outdated
@@ -92,27 +73,14 @@ The typical cycle for editing a recipe is:
the existing expected output to match the new output. Verify completely new test
cases by altering the `GenTests` method of the recipe. The recipe is required
to have 100% test coverage.
4. Run `led get-builder 'luci.flutter.prod:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
4. Run `led get-builder 'luci.flutter.try:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: point to staging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, TIL https://chrome-infra-auth.appspot.com/auth/groups/project-flutter-led-users is only for staging

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2022
@auto-submit auto-submit bot merged commit 97e018d into flutter:master Oct 19, 2022
This was referenced Oct 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
97e018d [docs] Refresh dev/bots/README.md (flutter/flutter#113464)
11ac3af
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
97e018d [docs] Refresh dev/bots/README.md (flutter/flutter#113464)
3ddff70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@godofredoc godofredoc Awaiting requested review from godofredoc

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaseyHillers @keyonghan