Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Android] Fix spell check integration test guarded function conflict #113541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2022
Merged

[Android] Fix spell check integration test guarded function conflict #113541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7c002d
Remove bringup and move test
camsim99 Oct 17, 2022
44ee297
Move test back and make main synchronous
camsim99 Oct 18, 2022
e102281
Cleanup
camsim99 Oct 18, 2022
034195d
Add back bringup:
camsim99 Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,7 +2104,7 @@ targets:
task_name: routing_test

- name: Linux_android spell_check_test
bringup: true # TESTING PURPOSES ONLY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to manually mark this as unflaky? We should have the flake bot auto handle the deflake process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think I misunderstood the meaning of this. What exactly does setting it to true do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any new target added to the CI and any target that has been flaky, bringup: true needs to be used so that we can validate the flakiness.
With bringup: true, the flaky bot will review these targets weekly and mark them as unflaky is no flake happens in recent 50 runs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/flutter/cocoon/blob/main/CI_YAML.md

Copy link
Contributor Author

@camsim99 camsim99 Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh got it. Thank you!! I'll revert this change. Is there a way for me to test for flakiness before submitting fixes this way?

bringup: true
recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60
Expand Down
2 changes: 1 addition & 1 deletion dev/integration_tests/spell_check/integration_test/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Future<bool> findTextSpanTree(
return true;
}

Future<void> main() async {
void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();

setUp(() {
Expand Down