[tool] Install the corresponding APK in flutter run
#113622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un` (flutter#112768)" (flutter#113614)" This reverts commit 4fa91c9.
| @@ -114,8 +114,8 @@ void main() { | |||
|
|
|||
| _findNextMatcherInList( | |||
| stdout, | |||
| (String line) => line.startsWith('Installing build/app/outputs/flutter-apk/app.apk...'), | |||
| 'Installing build/app/outputs/flutter-apk/app.apk...', | |||
| (String line) => line.startsWith('Installing build/app/outputs/flutter-apk/app-release.apk...'), | |||
There was a problem hiding this comment.
For posterity, this is the new fix for #113620 that caused the previous PR to get reverted.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #113614. Fix #111585, #113620.
The PR stops copying
app.apkforflutter runand makes the tool installs exactly the generated APK file, which corrects the console's output too. Also, SHA1 will be generated for all generated APKs in the batch.Filename comparison (DEBUG Mode)
Pre-launch Checklist
///).