Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update macOS gallery display name #113658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2022
Merged

Update macOS gallery display name #113658

merged 4 commits into from
Oct 20, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 19, 2022 •
edited
Loading

Update name of app from flutter_gallery to Flutter Gallery. Also update copyright.

See window title:
Screen Shot 2022-10-18 at 12 24 01 PM

Screen Shot 2022-10-18 at 12 23 11 PM

Now that it's called "Flutter Gallery", also turn on the hot_mode_dev_cycle_macos_target__benchmark check that validates the process with that name is properly killed on q, introduced in #113581. It's passing: https://ci.chromium.org/p/flutter/builders/try/Mac_ios%20hot_mode_dev_cycle_macos_target__benchmark/3628

flutter/dev/devicelab/lib/tasks/hot_mode_tests.dart

Lines 277 to 280 in 92df026

galleryProcesses = await getRunningProcesses(
processName: 'Flutter Gallery$exe',
processManager: const LocalProcessManager(),
);

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the platform-mac Building on or for macOS specifically label Oct 19, 2022
@jmagman jmagman self-assigned this Oct 19, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 19, 2022
@guidezpl
Copy link
Member

small suggestion to rename to "old Flutter Gallery" to help with the confusion between the integration test version and the public version

@jmagman
Copy link
Member Author

jmagman commented Oct 19, 2022

small suggestion to rename to "old Flutter Gallery" to help with the confusion between the integration test version and the public version

That doesn't match with the other platforms. We call the other one "new" Flutter Gallery in most places. I don't like either name since it doesn't scale for the inevitable third gallery.

@jmagman jmagman marked this pull request as ready for review October 19, 2022 21:05
@jmagman jmagman requested a review from keyonghan as a code owner October 19, 2022 21:05
@jmagman jmagman requested review from a-wallen and removed request for keyonghan October 19, 2022 21:07
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2022
@auto-submit auto-submit bot merged commit 4940513 into flutter:master Oct 20, 2022
This was referenced Oct 20, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
4940513 Update macOS gallery display name (flutter/flutter#113658)
1119e45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
4940513 Update macOS gallery display name (flutter/flutter#113658)
5cc750a
@jmagman jmagman deleted the gallery-macos-name branch October 21, 2022 01:48
@guidezpl
Copy link
Member

Fair, I'm putting my foot down at new_new_gallery

@jmagman
Copy link
Member Author

jmagman commented Oct 21, 2022

Fair, I'm putting my foot down at new_new_gallery

Or lean into the confidence of newest_gallery assuming there will never be another 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-wallen a-wallen a-wallen approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. platform-mac Building on or for macOS specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @guidezpl @a-wallen