Revert "[text_input] introduce TextInputControl" #113724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2fdfa29.
|
cc @jpnurmi |
|
This can be relanded after flutter/tests#165 lands. |
|
Looks like flutter/tests#165 was landed, @jpnurmi are you able to resubmit your PR #76072? |
|
Thanks, resubmitted: #113758 |
This was referenced Oct 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #76072
An apparent bugfix in the Dart SDK is newly revealing that this change broke super_editor in customer_testing.
superlistapp/super_editor#837
Unfortunately, super_editor is broken on Flutter master channel, so we are unable to simply apply the compensating change there and roll a new version into flutter/tests. Since the breakage is only revealed by a new Dart SDK, we are blocked from rolling the Engine into the framework until this is resolved. Since the roll blockage is a P0, we are preferring to solve it by landing a revert.