Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Resolve 113705: Separated longer running tests from runMisc to prevent flakiness from timeouts #113784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,32 @@ targets:
- bin/
- .ci.yaml

- name: Linux framework_tests_slow
bringup: true
recipe: flutter/flutter_drone
timeout: 60
properties:
dependencies: >-
[
{"dependency": "android_sdk", "version": "version:33v6"}
]
shard: framework_tests
subshard: slow
tags: >
["framework", "hostonly", "shard", "linux"]
runIf:
- dev/
- packages/flutter/
- packages/flutter_driver/
- packages/integration_test/
- packages/flutter_localizations/
- packages/fuchsia_remote_debug_protocol/
- packages/flutter_test/
- packages/flutter_goldens/
- packages/flutter_tools/
- bin/
- .ci.yaml

- name: Linux framework_tests_misc
recipe: flutter/flutter_drone
timeout: 60
Expand Down
17 changes: 13 additions & 4 deletions dev/bots/test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -965,14 +965,25 @@ Future<void> _runFrameworkTests() async {
);
}

// Tests that take longer than average to run. This is usually because they
// need to compile something large or make use of the analyzer for the test.
// These tests need to be platform agnostic as they are only run on a linux
// machine to save on execution time and cost.
Future<void> runSlow() async {
printProgress('${green}Running slow package tests$reset for directories other than packages/flutter');
await runTracingTests();
await runFixTests();
await runPrivateTests();
}

Future<void> runMisc() async {
printProgress('${green}Running package tests$reset for directories other than packages/flutter');
await _runTestHarnessTests();
await runExampleTests();
await _runDartTest(path.join(flutterRoot, 'dev', 'bots'));
await _runDartTest(path.join(flutterRoot, 'dev', 'devicelab'), ensurePrecompiledTool: false); // See https://github.com/flutter/flutter/issues/86209
await _runDartTest(path.join(flutterRoot, 'dev', 'conductor', 'core'), forceSingleCore: true);
// TODO(gspencergoog): Remove the exception for fatalWarnings once https://github.com/flutter/flutter/pull/91127 has landed.
// TODO(gspencergoog): Remove the exception for fatalWarnings once https://github.com/flutter/flutter/issues/113782 has landed.
await _runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'android_semantics_testing'), fatalWarnings: false);
await _runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'ui'));
await _runFlutterTest(path.join(flutterRoot, 'dev', 'manual_tests'));
Expand All @@ -991,9 +1002,6 @@ Future<void> _runFrameworkTests() async {
await _runFlutterTest(path.join(flutterRoot, 'packages', 'flutter_test'), options: soundNullSafetyOptions);
await _runFlutterTest(path.join(flutterRoot, 'packages', 'fuchsia_remote_debug_protocol'), options: soundNullSafetyOptions);
await _runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'non_nullable'), options: mixedModeNullSafetyOptions);
await runTracingTests();
await runFixTests();
await runPrivateTests();
const String httpClientWarning =
'Warning: At least one test in this suite creates an HttpClient. When\n'
'running a test suite that uses TestWidgetsFlutterBinding, all HTTP\n'
Expand Down Expand Up @@ -1023,6 +1031,7 @@ Future<void> _runFrameworkTests() async {
await selectSubshard(<String, ShardRunner>{
'widgets': runWidgets,
'libraries': runLibraries,
'slow': runSlow,
'misc': runMisc,
});
}
Expand Down