[flutter_tools] allow flutter drive to take screenshots when sent a terminating signal #114118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Oct 27, 2022
jmagman
reviewed
Oct 27, 2022
| @@ -286,6 +295,13 @@ class DriveCommand extends RunCommandBase { | |||
| androidEmulator: boolArgDeprecated('android-emulator'), | |||
| profileMemory: stringArgDeprecated('profile-memory'), | |||
| ); | |||
| // If the test is sent a signal, take a screenshot before exiting | |||
| final Map<ProcessSignal, Object> screenshotTokens = _registerScreenshotCallbacks((ProcessSignal signal) async { | |||
| _logger!.printError('Caught $signal'); | |||
There was a problem hiding this comment.
I'll let you merge this and will rebase #114111 on top.
Will do, I'm spending half my week staring at the build dashboard anyway |
8 tasks
This was referenced Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2022
…sent a terminating signal (flutter/flutter#114118)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 28, 2022
…sent a terminating signal (flutter/flutter#114118)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 28, 2022
…sent a terminating signal (flutter/flutter#114118)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2022
…sent a terminating signal (flutter/flutter#114118)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 28, 2022
…sent a terminating signal (flutter/flutter#114118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LUCI times out a step after 30 minutes, it first sends a signal (SIGTERM on *nix, SIGINT I think on Windows) to the last running process. If the CI build is running
flutter drive --screenshot=/path/to/screenshot ..., we should try to take a screenshot when this signal is sent.Should add debugging for #114025