Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix NPE in coverage collector #114177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix NPE in coverage collector #114177

merged 1 commit into from
Oct 28, 2022

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Oct 27, 2022

Fixes #114123

The NPE was happening when parsing ignore-file comments, so I added a test for that.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 27, 2022
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 27, 2022

auto label is removed for flutter/flutter, pr: 114177, due to - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2022
@liamappelbe liamappelbe merged commit ea0ddc9 into flutter:master Oct 28, 2022
@liamappelbe liamappelbe deleted the covnpe branch October 28, 2022 02:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Coverage throwing Error in Coverage Collector
2 participants