-
Notifications
You must be signed in to change notification settings - Fork 30.4k
Refactor fix_data.yaml #114192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor fix_data.yaml #114192
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a7253da
Refactor fix_data.yaml
Piinks 7d0984d
++
Piinks 50b29e3
lib, not lib/src
Piinks 5c44736
Nit
Piinks 37a2765
Merge branch 'master' of github.com:flutter/flutter into fixData
Piinks 64afeb0
Nit
Piinks 59fde33
Merge branch 'master' of github.com:flutter/flutter into fixData
Piinks eed0dae
Update packages/flutter/test_fixes/material/app_bar_theme.dart
Piinks 7610f9a
Merge branch 'fixData' of github.com:Piinks/flutter into fixData
Piinks a13a9b7
Fix copy paste errors
Piinks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
++
- Loading branch information
commit 7d0984d896adcb0a4ad5f83b0fe9d5e192379ed5
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright 2014 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| void main() { | ||
| // Changes made in https://github.com/flutter/flutter/pull/86198 | ||
| AppBar appBar = AppBar(); | ||
| appBar = AppBar(brightness: Brightness.light); | ||
| appBar = AppBar(brightness: Brightness.dark); | ||
| appBar = AppBar(error: ''); | ||
| appBar.brightness; | ||
|
|
||
| TextTheme myTextTheme = TextTheme(); | ||
| AppBar appBar = AppBar(); | ||
| appBar = AppBar(textTheme: myTextTheme); | ||
| appBar = AppBar(textTheme: myTextTheme); | ||
|
|
||
| AppBar appBar = AppBar(); | ||
| appBar = AppBar(backwardsCompatibility: true); | ||
| appBar = AppBar(backwardsCompatibility: false)); | ||
| appBar.backwardsCompatibility; // Removing field reference not supported. | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright 2014 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| void main() { | ||
| // Changes made in https://github.com/flutter/flutter/pull/86198 | ||
| AppBar appBar = AppBar(); | ||
| appBar = AppBar(systemOverlayStyle: SystemUiOverlayStyle.dark); | ||
| appBar = AppBar(systemOverlayStyle: SystemUiOverlayStyle.light); | ||
| appBar = AppBar(error: ''); | ||
| appBar.systemOverlayStyle; | ||
|
|
||
| TextTheme myTextTheme = TextTheme(); | ||
| AppBar appBar = AppBar(); | ||
| appBar = AppBar(toolbarTextStyle: myTextTheme.bodyMedium, titleTextStyle: myTextTheme.titleLarge); | ||
| appBar = AppBar(toolbarTextStyle: myTextTheme.bodyMedium, titleTextStyle: myTextTheme.titleLarge); | ||
|
|
||
| AppBar appBar = AppBar(); | ||
| appBar = AppBar(); | ||
| appBar = AppBar()); | ||
| appBar.backwardsCompatibility; // Removing field reference not supported. | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Copyright 2014 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| void main() { | ||
| // Changes made in https://github.com/flutter/flutter/pull/86198 | ||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(brightness: Brightness.light); | ||
| appBarTheme = AppBarTheme(brightness: Brightness.dark); | ||
| appBarTheme = AppBarTheme(error: ''); | ||
| appBarTheme = appBarTheme.copyWith(error: ''); | ||
| appBarTheme = appBarTheme.copyWith(brightness: Brightness.light); | ||
| appBarTheme = appBarTheme.copyWith(brightness: Brightness.dark); | ||
| appBarTheme.brightness; | ||
|
|
||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(textTheme: myTextTheme); | ||
| appBarTheme = AppBarTheme(textTheme: myTextTheme); | ||
| appBarTheme = appBarTheme.copyWith(textTheme: myTextTheme); | ||
| appBarTheme = appBarTheme.copyWith(textTheme: myTextTheme); | ||
|
|
||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(backwardsCompatibility: true); | ||
| appBarTheme = AppBarTheme(backwardsCompatibility: false); | ||
| appBarTheme = appBarTheme.copyWith(backwardsCompatibility: true); | ||
| appBarTheme = appBarTheme.copyWith(backwardsCompatibility: false); | ||
| appBarTheme.backwardsCompatibility; // Removing field reference not supported. | ||
|
|
||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme.color; | ||
| } | ||
33 changes: 33 additions & 0 deletions
33
packages/flutter/test_fixes/material/app_bar_theme.dart.expect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Copyright 2014 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| void main() { | ||
| // Changes made in https://github.com/flutter/flutter/pull/86198 | ||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.dark); | ||
| appBarTheme = AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.light); | ||
| appBarTheme = AppBarTheme(error: ''); | ||
| appBarTheme = appBarTheme.copyWith(error: ''); | ||
| appBarTheme = appBarTheme.copyWith(systemOverlayStyle: SystemUiOverlayStyle.dark); | ||
| appBarTheme = appBarTheme.copyWith(systemOverlayStyle: SystemUiOverlayStyle.light); | ||
| appBarTheme.systemOverlayStyle; | ||
|
|
||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(toolbarTextStyle: myTextTheme.bodyMedium, titleTextStyle: myTextTheme.titleLarge); | ||
| appBarTheme = AppBarTheme(toolbarTextStyle: myTextTheme.bodyMedium, titleTextStyle: myTextTheme.titleLarge); | ||
| appBarTheme = appBarTheme.copyWith(toolbarTextStyle: myTextTheme.bodyMedium, titleTextStyle: myTextTheme.titleLarge); | ||
| appBarTheme = appBarTheme.copyWith(toolbarTextStyle: myTextTheme.bodyMedium, titleTextStyle: myTextTheme.titleLarge); | ||
|
|
||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(); | ||
| appBarTheme = AppBarTheme(); | ||
| appBarTheme = appBarTheme.copyWith(); | ||
| appBarTheme = appBarTheme.copyWith(); | ||
| appBarTheme.backwardsCompatibility; // Removing field reference not supported. | ||
|
|
||
| AppBarTheme appBarTheme = AppBarTheme(); | ||
| appBarTheme.backgroundColor; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Copyright 2014 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| void main() { | ||
| // Changes made in https://github.com/flutter/flutter/pull/93427 | ||
| ColorScheme colorScheme = ColorScheme(); | ||
| colorScheme = ColorScheme(primaryVariant: Colors.black, secondaryVariant: Colors.white); | ||
| colorScheme = ColorScheme.light(primaryVariant: Colors.black, secondaryVariant: Colors.white); | ||
| colorScheme = ColorScheme.dark(primaryVariant: Colors.black, secondaryVariant: Colors.white); | ||
| colorScheme = ColorScheme.highContrastLight(primaryVariant: Colors.black, secondaryVariant: Colors.white); | ||
| colorScheme = ColorScheme.highContrastDark(primaryVariant: Colors.black, secondaryVariant: Colors.white); | ||
| colorScheme = colorScheme.copyWith(primaryVariant: Colors.black, secondaryVariant: Colors.white); | ||
| colorScheme.primaryVariant; // Removing field reference not supported. | ||
| colorScheme.secondaryVariant; | ||
| } |
18 changes: 18 additions & 0 deletions
18
packages/flutter/test_fixes/material/color_scheme.dart.expect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Copyright 2014 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| void main() { | ||
| // Changes made in https://github.com/flutter/flutter/pull/93427 | ||
| ColorScheme colorScheme = ColorScheme(); | ||
| colorScheme = ColorScheme(); | ||
| colorScheme = ColorScheme.light(); | ||
| colorScheme = ColorScheme.dark(); | ||
| colorScheme = ColorScheme.highContrastLight(); | ||
| colorScheme = ColorScheme.highContrastDark(); | ||
| colorScheme = colorScheme.copyWith(); | ||
| colorScheme.primaryContainer; // Removing field reference not supported. | ||
| colorScheme.secondaryContainer; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.