Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6 (#114198) #114236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6 (#114198) #114236

merged 1 commit into from
Oct 28, 2022

Conversation

christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Oct 28, 2022 •
edited
Loading

This reverts commit 9b59a4e due to #114235.

Reverts #114204

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine repository. See also e: labels. label Oct 28, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

auto label is removed for flutter/flutter, pr: 114236, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

auto label is removed for flutter/flutter, pr: 114236, due to Validations Fail.

@christopherfujino christopherfujino added autosubmit Merge PR when tree becomes green via auto submit App revert Autorevert PR (with "Reason for revert:" comment) labels Oct 28, 2022
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

auto label is removed for flutter/flutter, pr: 114236, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

auto label is removed for flutter/flutter, pr: 114236, due to Validations Fail.

@christopherfujino christopherfujino added autosubmit Merge PR when tree becomes green via auto submit App revert Autorevert PR (with "Reason for revert:" comment) labels Oct 28, 2022
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

auto label is removed for flutter/flutter, pr: 114236, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

auto label is removed for flutter/flutter, pr: 114236, due to Validations Fail.

@christopherfujino christopherfujino added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 28, 2022
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 28, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 28, 2022

revert label is removed for flutter/flutter, pr#: 114236, Failed to merge pr#: 114236 with At least 1 approving review is required by reviewers with write access..

@ricardoamador ricardoamador added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 28, 2022
@auto-submit auto-submit bot merged commit 56c880a into flutter:master Oct 28, 2022
@auto-submit auto-submit bot mentioned this pull request Oct 28, 2022
Closed
@christopherfujino christopherfujino deleted the revert-engine-roll branch October 28, 2022 17:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 28, 2022
@engine-flutter-autoroll
56c880a Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6…
046443a 
… (#114198) (flutter/flutter#114236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 28, 2022
@engine-flutter-autoroll
56c880a Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6…
55a80d4 
… (#114198) (flutter/flutter#114236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 28, 2022
@engine-flutter-autoroll
56c880a Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6…
a57a95d 
… (#114198) (flutter/flutter#114236)
@ricardoamador ricardoamador mentioned this pull request Oct 28, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 29, 2022
@engine-flutter-autoroll
56c880a Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6…
d5f7979 
… (#114198) (flutter/flutter#114236)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 29, 2022
@engine-flutter-autoroll
56c880a Revert "Roll Flutter Engine from d90e5b7372a3 to b5c52563bbb6…
c13ae60 
… (#114198) (flutter/flutter#114236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. revert Autorevert PR (with "Reason for revert:" comment)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherfujino @fluttergithubbot @ricardoamador