Add const to TextInputFormatter #114592

shogohida · 2022-11-03T09:34:19Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

shogohida · 2022-11-03T10:58:12Z

It seems test failures are not related to the change I made so I decided to open this pull request

LongCatIsLooong · 2022-11-03T21:59:22Z

Thanks for contributing. The change makes sense to me, but the test failures are related, "Linux analyze" is complaining there's missing documentation. Also this seems to be testable, could you add a test for that?

shogohida · 2022-11-04T13:12:13Z

@LongCatIsLooong
Thanks for your comment! I have 2 questions.

I couldn't see that "Linux analyze" is complaining there's missing documentation... I saw the error message below but nothing else. Could you show me the specific point where Linux analyze is complaining? I will fix the code according to that point.

For your convenience, the error messages reported above are repeated here:
Command exited with exit code 1 but expected: zero exit code.
Command: bin/flutter analyze --flutter-repo
Relative working directory: .
Command exited with exit code 1 but expected: zero exit code.
Command: bin/flutter analyze --flutter-repo --watch --benchmark
Relative working directory: .

Is there any good example in Flutter code I can refer to in order to write a test? I wasn't sure if I should write a test to examine const constructer can be created in TextInputFormatter class or its sub classes.

Thanks for your support!

LongCatIsLooong · 2022-11-04T17:03:46Z

You should be able to find plenty of examples here: https://github.com/flutter/flutter/blob/master/packages/flutter/test/services/text_formatter_test.dart.

The test failure is here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8798526700594975537/+/u/Analyze/analyze/test_stdout. The new public constructor needs to be documented.

flutter-dashboard · 2022-11-05T07:23:04Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

shogohida · 2022-11-05T17:23:39Z

@LongCatIsLooong
I added documentation and tests but it seems tests I added are wrong.... I tried to create tests referring to the file you shared but I don't know yet what kind of tests I should add.

Could you give me a clear code example of tests? It would be so helpful. Thanks in advance.

goderbauer · 2022-11-09T14:00:04Z

packages/flutter/test/services/text_formatter_test.dart

@@ -7,6 +7,13 @@ import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';

 void main() {
+  test('test const constructor', () {
+    const testValue1 = TextInputFormatter();


TextInputFormatter is an abstract class and cannot be instantiated.

@goderbauer
Thanks for your comment. Should I write tests for const constructors of subclasses instead?

LongCatIsLooong · 2022-11-15T17:50:52Z

For tests I think the ones you added were fine, just have to make sure you can add const to subclasses. But I don't think it makes sense to add a new const constructor that takes no parameters for every subclass.

shogohida · 2022-11-22T16:42:58Z

@LongCatIsLooong
Thanks for your comment! Are these changes fine then? I thought this is what you said above

ad66a5d

LongCatIsLooong · 2022-11-23T17:33:42Z

packages/flutter/test/services/text_formatter_test.dart

@@ -7,6 +7,19 @@ import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';

 void main() {
+  test('test const constructor', () {
+    const testValue1 = _SimpleTextInputFormatter();


These don't have a const constructor or a constructor that takes 0 arguments. Could you create a concrete TextInputFormatter sub-class in the test file, with a const constructor?

Sorry for replying late. Is my understanding correct?

8b96bf0

I don't think you can declare inline classes in dart. You can try out the test by following this section from the wiki

goderbauer · 2022-12-06T23:16:13Z

(triage): @shogohida looks like the checks failed due to some infra issue. Could you merge in the latest master to kick the checks again? Thanks.

…lutter/engine#37745) (flutter#115658)

* Allows pushing page based route as pageless route * update

* delete screenshot_test.dart * remove image dep * pub get

…lutter#115672) * a76ec9158 Roll Fuchsia Linux SDK from lnmSnyJi-2H07tBnV... to WdtwlLEce90PjFJ9z... (flutter/engine#37747) * 44e2f5854 [Impeller] Change texture upload pipeline in Vulkan (flutter/engine#37623) * 6a3ad3c14 Roll Skia from 345bceacd298 to 5270b1d26b5f (4 revisions) (flutter/engine#37748) * 01271891c Do not abort if a MultiFrameCodec is unable to allocate a bitmap buffer (flutter/engine#37534) * 54232a4c3 Roll Skia from 5270b1d26b5f to cf967e6b1c00 (5 revisions) (flutter/engine#37751) * 30aa3cc38 [fuchsia][a11y] Set explicit hit regions in flatland embedder (flutter/engine#37338) * da07c33d2 Make NotifyIdle reject close and past deadlines. (flutter/engine#37737) * e3844cc1e Add third_party/dart/third_party/binaryen/src as a dependency (flutter/engine#37749) * aeb2cd95b [Impeller] use SSBOs for gradients where supported (metal/vulkan) (flutter/engine#37654) * e8aa1c192 Roll Skia from cf967e6b1c00 to f1f59de17204 (2 revisions) (flutter/engine#37756) * 4311774fb [Impeller] register modern shaders on Vulkan too (flutter/engine#37757) * 8e4a718d0 Made FlutterTextField that outlive FlutterTextPlatformNode not crash (flutter/engine#37735) * 446a09dfc [macOS] Use consistent filenames for tests (flutter/engine#37755) * 7a390f97c Roll Skia from f1f59de17204 to 12f01bc5b57e (1 revision) (flutter/engine#37760)

…5680) This reverts commit cf2c9f6.

…7758) (flutter#115675)

…115683)

…lutter/engine#37767) (flutter#115684)

…lutter/engine#37771) (flutter#115685)

…OCs_7GEK... (flutter/engine#37773) (flutter#115686)

…e8PoqMQWgw... (flutter/engine#37775) (flutter#115687)

…lutter/engine#37776) (flutter#115689)

…lutter#116620) * 143977b53 Roll Skia from b63a254727f3 to 13e5241ce8b7 (6 revisions) (flutter/engine#38106) * 9554754ac [web:canvaskit] test zero font size (flutter/engine#37916) * 4f22c2789 Roll Skia from 13e5241ce8b7 to aea62b0970c3 (2 revisions) (flutter/engine#38107)

* Remove flaky label * Have test install debug version * Fix test * Undo change * Properly test change * Empty-Commit * Revert testing changes

* Add ListenableBuilder with examples * Add tests * Add tests * Fix Test * Change AnimatedBuilder to be a subclass of ListenableBuilder

* Make some minor changes in preparation for updating the Time Picker to M3 * Revert OutlineInputBorder.borderRadius type change * Revert more OutlineInputBorder.borderRadius changes.

…lutter#116632) * 267f0d849 Roll Skia from aea62b0970c3 to dd3285a80b23 (1 revision) (flutter/engine#38111) * 5ad341776 [Impeller] Remove unused flag enable-impeller-vulkan. (flutter/engine#38109) * 185e2f3d4 Pin the analyzer package version in lib/web_ui (flutter/engine#38114)

…lutter#116633) * 5429243d3 [Impeller Scene] Render imported meshes (flutter/engine#38097) * 67254d6e4 Use announce function in live region (flutter/engine#38084)

shogohida · 2022-12-07T13:10:42Z

@goderbauer
Thanks for your comment. I tried to rebase but it seems I made mistakes in the process. I will make a new pull request from the latest master and close this one for a moment.

I'm very sorry for the inconvenience.

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Nov 3, 2022

shogohida mentioned this pull request Nov 3, 2022

Add const constructor to TextInputFormatter #114401

Closed

shogohida marked this pull request as ready for review November 3, 2022 10:58

justinmc requested a review from LongCatIsLooong November 3, 2022 21:52

shogohida marked this pull request as draft November 5, 2022 07:17

goderbauer reviewed Nov 9, 2022

View reviewed changes

LongCatIsLooong reviewed Nov 23, 2022

View reviewed changes

engine-flutter-autoroll and others added 13 commits December 7, 2022 22:01

b32c3a307 Roll Skia from ab054a88d7c7 to 345bceacd298 (3 revisions) (f…

0d42a54

…lutter/engine#37745) (flutter#115658)

Allows pushing page based route as pageless route (flutter#114362)

2530ee3

* Allows pushing page based route as pageless route * update

nav drawer (flutter#115668)

ccc4336

Remove package:image dependency (flutter#115674)

78b11f4

* delete screenshot_test.dart * remove image dep * pub get

Revert "Remove package:image dependency (flutter#115674)" (flutter#11…

7db1e2e

…5680) This reverts commit cf2c9f6.

a77dfaff3 Remove Linux Web Engine from recipes CQ (flutter/engine#3…

ee6f351

…7758) (flutter#115675)

f81ac3b19 Fix glyph sampling overlap (flutter/engine#37764) (flutter#…

7cf86ba

…115683)

cef11cb9a Roll Skia from 12f01bc5b57e to c53d8cf5b823 (4 revisions) (f…

d491a0a

…lutter/engine#37767) (flutter#115684)

6da59402e Roll Skia from c53d8cf5b823 to 0c1fcbe97b1f (1 revision) (f…

a90d10b

…lutter/engine#37771) (flutter#115685)

91bc694eb Roll Fuchsia Mac SDK from tklUfTsSOVKk49tYq... to UcfQiA4PB…

cdd33c8

…OCs_7GEK... (flutter/engine#37773) (flutter#115686)

2d5e0667e Roll Fuchsia Linux SDK from WdtwlLEce90PjFJ9z... to qc20R_3…

0a111d0

…e8PoqMQWgw... (flutter/engine#37775) (flutter#115687)

916fd798d Roll Skia from 0c1fcbe97b1f to ad354e712b96 (2 revisions) (f…

7f8a8fb

…lutter/engine#37776) (flutter#115689)

mit-mit and others added 7 commits December 7, 2022 22:02

Adjust upper Dart SDK constraint (flutter#116586)

dc90aa8

[Android] Fix Linux Android flavors_test (flutter#116129)

21c6749

* Remove flaky label * Have test install debug version * Fix test * Undo change * Properly test change * Empty-Commit * Revert testing changes

Add ListenableBuilder with examples (flutter#116543)

4e6c332

* Add ListenableBuilder with examples * Add tests * Add tests * Fix Test * Change AnimatedBuilder to be a subclass of ListenableBuilder

Time picker precursors (flutter#116450)

8e61026

* Make some minor changes in preparation for updating the Time Picker to M3 * Revert OutlineInputBorder.borderRadius type change * Revert more OutlineInputBorder.borderRadius changes.

Roll Flutter Engine from 185e2f3d451c to 67254d6e4b03 (2 revisions) (f…

45242d7

…lutter#116633) * 5429243d3 [Impeller Scene] Render imported meshes (flutter/engine#38097) * 67254d6e4 Use announce function in live region (flutter/engine#38084)

shogohida changed the base branch from master to 3.3 December 7, 2022 13:04

shogohida changed the base branch from 3.3 to master December 7, 2022 13:04

shogohida closed this Dec 7, 2022

shogohida mentioned this pull request Dec 7, 2022

Add const constructor to TextInputFormatter #116654

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add const to TextInputFormatter #114592

Add const to TextInputFormatter #114592

Uh oh!

shogohida commented Nov 3, 2022 •

edited

Loading

Uh oh!

shogohida commented Nov 3, 2022

Uh oh!

LongCatIsLooong commented Nov 3, 2022

Uh oh!

shogohida commented Nov 4, 2022

Uh oh!

LongCatIsLooong commented Nov 4, 2022

Uh oh!

flutter-dashboard bot commented Nov 5, 2022

Uh oh!

shogohida commented Nov 5, 2022

Uh oh!

goderbauer Nov 9, 2022

Uh oh!

shogohida Nov 12, 2022

Uh oh!

LongCatIsLooong commented Nov 15, 2022

Uh oh!

shogohida commented Nov 22, 2022 •

edited

Loading

Uh oh!

LongCatIsLooong Nov 23, 2022

Uh oh!

shogohida Nov 28, 2022

Uh oh!

LongCatIsLooong Nov 28, 2022

Uh oh!

goderbauer commented Dec 6, 2022

Uh oh!

shogohida commented Dec 7, 2022 •

edited

Loading

Uh oh!

Uh oh!

Add const to TextInputFormatter #114592

Add const to TextInputFormatter #114592

Uh oh!

Conversation

shogohida commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

shogohida commented Nov 3, 2022

Uh oh!

LongCatIsLooong commented Nov 3, 2022

Uh oh!

shogohida commented Nov 4, 2022

Uh oh!

LongCatIsLooong commented Nov 4, 2022

Uh oh!

flutter-dashboard bot commented Nov 5, 2022

Uh oh!

shogohida commented Nov 5, 2022

Uh oh!

goderbauer Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

shogohida Nov 12, 2022

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong commented Nov 15, 2022

Uh oh!

shogohida commented Nov 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LongCatIsLooong Nov 23, 2022

Choose a reason for hiding this comment

Uh oh!

shogohida Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Dec 6, 2022

Uh oh!

shogohida commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shogohida commented Nov 3, 2022 •

edited

Loading

shogohida commented Nov 22, 2022 •

edited

Loading

shogohida commented Dec 7, 2022 •

edited

Loading