Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Decoding Flutter videos to API docs #116454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2023
Merged

Add Decoding Flutter videos to API docs #116454

merged 3 commits into from
Jan 25, 2023

Conversation

tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Dec 3, 2022

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Dec 3, 2022
@tvolkert tvolkert requested a review from Piinks December 3, 2022 06:28
Piinks
Piinks reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I ended up getting side tracked watching these!

packages/flutter/lib/src/widgets/media_query.dart
@@ -234,6 +234,8 @@ class MediaQueryData {
///
/// Padding is derived from the values of [viewInsets] and [viewPadding].
///
/// {@youtube 560 315 https://www.youtube.com/watch?v=ceCo8U0XHqw}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this above on viewInsets as well?

packages/flutter/lib/src/widgets/primary_scroll_controller.dart
@@ -17,6 +17,8 @@ const Set<TargetPlatform> _kMobilePlatforms = <TargetPlatform>{

/// Associates a [ScrollController] with a subtree.
///
/// {@youtube 560 315 https://www.youtube.com/watch?v=33_0ABjFJUU}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this one to ScrollView.primary as well? It's templated for every subclass with primary.

@tvolkert
Copy link
Contributor Author

Comments addressed - PTAL 🙂

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Jan 25, 2023
Piinks
Piinks approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2023
@auto-submit auto-submit bot merged commit 351466a into flutter:master Jan 25, 2023
This was referenced Jan 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 25, 2023
@engine-flutter-autoroll
351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)
031e724
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 25, 2023
@engine-flutter-autoroll
351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)
5453ae0
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 25, 2023
@engine-flutter-autoroll
Roll Flutter from c35efda to a815ee6 (22 revisions) (#3089)
a510db7 
* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819)

* 4d25030 Add leak_tracker as dev_dependency.  (flutter/flutter#118952)

* e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638)

* d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081)

* 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999)

* 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849)

* 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646)

* a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087)

* c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089)

* 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075)

* 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090)

* 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093)

* bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095)

* 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) (flutter/flutter#119097)

* 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) (flutter/flutter#119098)

* 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872)

* b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114) (flutter/flutter#119099)

* 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)

* 318f875 Pass through magnifierConfiguration (flutter/flutter#118270)

* eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter/engine#39122) (flutter/flutter#119126)

* 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792)

* a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123) (flutter/flutter#119129)
@tvolkert tvolkert deleted the df branch January 25, 2023 17:44
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Jan 25, 2023
@engine-flutter-autoroll
Roll Flutter from c35efda to a815ee6 (22 revisions) (#7025)
dc8ad77 
* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819)

* 4d25030 Add leak_tracker as dev_dependency.  (flutter/flutter#118952)

* e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638)

* d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081)

* 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999)

* 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849)

* 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646)

* a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087)

* c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089)

* 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075)

* 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090)

* 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093)

* bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095)

* 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) (flutter/flutter#119097)

* 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) (flutter/flutter#119098)

* 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872)

* b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114) (flutter/flutter#119099)

* 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)

* 318f875 Pass through magnifierConfiguration (flutter/flutter#118270)

* eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter/engine#39122) (flutter/flutter#119126)

* 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792)

* a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123) (flutter/flutter#119129)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#7025)
acdec79 
* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819)

* 4d25030 Add leak_tracker as dev_dependency.  (flutter/flutter#118952)

* e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638)

* d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081)

* 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999)

* 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849)

* 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646)

* a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087)

* c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089)

* 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075)

* 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090)

* 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093)

* bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095)

* 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) (flutter/flutter#119097)

* 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) (flutter/flutter#119098)

* 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872)

* b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114) (flutter/flutter#119099)

* 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454)

* 318f875 Pass through magnifierConfiguration (flutter/flutter#118270)

* eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter/engine#39122) (flutter/flutter#119126)

* 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792)

* a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123) (flutter/flutter#119129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvolkert @Piinks