Fix some Focus related documentation typos #118576

bleroux · 2023-01-16T15:59:22Z

Description

While learning more the inner workings of the focus management, I spotted some minor typos on this great documentation. Also fixed some formatting nits in tests source code.

Related Issue

Fixes #118572

Tests

Documentation only PR.

gspencergoog

Thanks!

gspencergoog · 2023-01-17T16:26:18Z

packages/flutter/test/widgets/focus_traversal_test.dart

@@ -1474,7 +1474,7 @@ void main() {
      /// Layout is:
      ///           [0, 1]
      ///    [0, 0] [    ] [0, 2]
-      ///    [  1,  0 ] [1, 1] [1, 2]
+      ///    [1, 0] [1, 1] [1, 2]


Actually, that was intentional, to show that the button wasn't the same size as the one above it.

Ah ok, let me restore this before merging. 😅

…18576)

* a3629a2 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640)

…18576)

* Fix focus area documentation typos * Restore intentional spaces that illustrate bigger buttons

…18576)

@pragma

* da5f8cf Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (flutter/flutter#118505) * baefecc 35479aa1c Roll Fuchsia Mac SDK from 21nYb648VWbpxc36t... to w0hr1ZMvYGJnWInwK... (flutter/engine#38880) (flutter/flutter#118509) * ca300ce 25cb82272 Add include to make g3 happy (flutter/engine#38850) (flutter/flutter#118510) * 1220245 f79030440 Roll Skia from c72c7bf7e45b to c64a10d525d1 (7 revisions) (flutter/engine#38858) (flutter/flutter#118511) * 7188c3e Update documentation about accent color (flutter/flutter#116778) * 8c2fdb8 M3 Button padding adjustments (flutter/flutter#118449) * f22280a Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598) * cc7845e Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098) * a3629a2 Roll Plugins from 92a5367d58df to 4e5cf2d2da27 (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640) * 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d2da27 to 11361d01099d (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421)

* a3629a2 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640)

bleroux force-pushed the fix_focus_documentation_typos branch 3 times, most recently from 714785b to 60dc79c Compare January 16, 2023 20:59

bleroux requested a review from gspencergoog January 16, 2023 21:34

bleroux mentioned this pull request Jan 17, 2023

Add reference to HardwareKeyboard in RawKeyboard documentation #118607

Merged

gspencergoog approved these changes Jan 17, 2023

View reviewed changes

goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Jan 17, 2023

bleroux force-pushed the fix_focus_documentation_typos branch from 60dc79c to 57ac8f3 Compare January 17, 2023 21:32

bleroux added 2 commits January 17, 2023 23:19

Fix focus area documentation typos

2bdd186

Restore intentional spaces that illustrate bigger buttons

aa61306

bleroux force-pushed the fix_focus_documentation_typos branch from 57ac8f3 to aa61306 Compare January 17, 2023 22:20

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 18, 2023

auto-submit bot merged commit 0eaa83a into flutter:master Jan 18, 2023

This was referenced Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 973cff40b402 (17 revisions) flutter/packages#3061

Closed

Roll Flutter from cc7845e71a9d to 973cff40b402 (9 revisions) flutter/plugins#6987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

0441c21

…18576)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 18, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

45c8bb9

…18576)

engine-flutter-autoroll mentioned this pull request Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 3348987546df (18 revisions) flutter/packages#3062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

fb4d6eb

…18576)

engine-flutter-autoroll mentioned this pull request Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 62775206461c (19 revisions) flutter/packages#3063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

a3944e9

…18576)

engine-flutter-autoroll mentioned this pull request Jan 18, 2023

Roll Flutter from 68dd63d66ba6 to 997d43618dc7 (20 revisions) flutter/packages#3064

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

711099b

…18576)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to 06909ccfa4ef (42 revisions) flutter/packages#3068

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

8910d44

…18576)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to 46c7fd14da02 (43 revisions) flutter/packages#3069

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

738ee13

…18576)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to b9ab64049152 (44 revisions) flutter/packages#3070

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

096f455

…18576)

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to ea36b3a5a708 (45 revisions) flutter/packages#3071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

1ae6c6e

…18576)

gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023

Fix some Focus related documentation typos (flutter#118576)

80a792f

* Fix focus area documentation typos * Restore intentional spaces that illustrate bigger buttons

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 68dd63d66ba6 to 73096fd96ef5 (57 revisions) flutter/packages#3073

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2023

0eaa83a Fix some Focus related documentation typos (flutter/flutter#1…

b0eb60e

…18576)

bleroux deleted the fix_focus_documentation_typos branch January 30, 2023 11:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix some Focus related documentation typos #118576

Fix some Focus related documentation typos #118576

Uh oh!

bleroux commented Jan 16, 2023

Uh oh!

gspencergoog left a comment

Uh oh!

gspencergoog Jan 17, 2023

Uh oh!

bleroux Jan 17, 2023

Uh oh!

Uh oh!

Fix some Focus related documentation typos #118576

Fix some Focus related documentation typos #118576

Uh oh!

Conversation

bleroux commented Jan 16, 2023

Description

Related Issue

Tests

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

gspencergoog Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

bleroux Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!