Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Update android defines test to use emulator" #118928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

ricardoamador
Copy link
Contributor

Reverts #118808

@ricardoamador ricardoamador added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 21, 2023
@auto-submit auto-submit bot merged commit bae4c1d into master Jan 21, 2023
@auto-submit auto-submit bot deleted the revert-118808-android_defines_target branch January 21, 2023 01:06
@ricardoamador
Copy link
Contributor Author

Not sure how you are supposed to pass dimension now.
image

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 21, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 21, 2023
* ec6ff90 Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893)

* 492d572 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894)

* f291eb3 Remove unnecessary null checks in integration_test (flutter/flutter#118861)

* ab3c822 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842)

* bf72f5e 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899)

* a07e8a6 [reland] Support wireless debugging (flutter/flutter#118895)

* 3c769ef Cupertino navbar ellipsis fix (flutter/flutter#118841)

* d1be731 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909)

* c0ad6ad Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706)

* 8372001 Remove unnecessary null checks in flutter_test (flutter/flutter#118865)

* 288a773 Remove unnecessary null checks in flutter_driver (flutter/flutter#118864)

* bb73121 Remove unnecessary null checks in flutter/test (flutter/flutter#118905)

* 15bc4e4 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693)

* 1cdaf9e e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913)

* 49e025d Update android defines test to use emulator (flutter/flutter#118808)

* bae4c1d Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928)

* 9837eb6 Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923)

* 25843bd Remove macOS impeller benchmarks (flutter/flutter#118917)

* 70cecf6 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844)

* c757df3 Remove unnecessary null checks in dev/bots (flutter/flutter#118846)

* 5d74b5c Remove unnecessary null checks in flutter/painting (flutter/flutter#118925)

* 7272c80 Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922)

* 2baea2f 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933)

* 8d60a8c Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938)

* 5ccdb81 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942)

* b1f4070 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 22, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 22, 2023
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Jan 22, 2023
* 3c769ef Cupertino navbar ellipsis fix (flutter/flutter#118841)

* d1be731 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909)

* c0ad6ad Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706)

* 8372001 Remove unnecessary null checks in flutter_test (flutter/flutter#118865)

* 288a773 Remove unnecessary null checks in flutter_driver (flutter/flutter#118864)

* bb73121 Remove unnecessary null checks in flutter/test (flutter/flutter#118905)

* 15bc4e4 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693)

* 1cdaf9e e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913)

* 49e025d Update android defines test to use emulator (flutter/flutter#118808)

* bae4c1d Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928)

* 9837eb6 Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923)

* 25843bd Remove macOS impeller benchmarks (flutter/flutter#118917)

* 70cecf6 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844)

* c757df3 Remove unnecessary null checks in dev/bots (flutter/flutter#118846)

* 5d74b5c Remove unnecessary null checks in flutter/painting (flutter/flutter#118925)

* 7272c80 Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922)

* 2baea2f 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933)

* 8d60a8c Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938)

* 5ccdb81 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942)

* b1f4070 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944)

* 8065887 Add transform flip (flutter/flutter#116705)

* 68b6e72 406dce64f Roll Fuchsia Mac SDK from ZTKDeVL1HDAwsZdhl... to l7jVM3Urw73TVWfee... (flutter/engine#39050) (flutter/flutter#118964)

* cf628ad aa194347a Roll Fuchsia Linux SDK from S6wQW1tLFe-YnReaZ... to l3c_b-vRr-o6ZFX_M... (flutter/engine#39055) (flutter/flutter#118968)

* f33e8d3 2a2dfaafb Roll Fuchsia Mac SDK from l7jVM3Urw73TVWfee... to 5TQ9IL4-Yu3KHCR-H... (flutter/engine#39056) (flutter/flutter#118969)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
* 3c769ef Cupertino navbar ellipsis fix (flutter/flutter#118841)

* d1be731 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909)

* c0ad6ad Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706)

* 8372001 Remove unnecessary null checks in flutter_test (flutter/flutter#118865)

* 288a773 Remove unnecessary null checks in flutter_driver (flutter/flutter#118864)

* bb73121 Remove unnecessary null checks in flutter/test (flutter/flutter#118905)

* 15bc4e4 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693)

* 1cdaf9e e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913)

* 49e025d Update android defines test to use emulator (flutter/flutter#118808)

* bae4c1d Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928)

* 9837eb6 Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923)

* 25843bd Remove macOS impeller benchmarks (flutter/flutter#118917)

* 70cecf6 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844)

* c757df3 Remove unnecessary null checks in dev/bots (flutter/flutter#118846)

* 5d74b5c Remove unnecessary null checks in flutter/painting (flutter/flutter#118925)

* 7272c80 Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922)

* 2baea2f 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933)

* 8d60a8c Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938)

* 5ccdb81 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942)

* b1f4070 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944)

* 8065887 Add transform flip (flutter/flutter#116705)

* 68b6e72 406dce64f Roll Fuchsia Mac SDK from ZTKDeVL1HDAwsZdhl... to l7jVM3Urw73TVWfee... (flutter/engine#39050) (flutter/flutter#118964)

* cf628ad aa194347a Roll Fuchsia Linux SDK from S6wQW1tLFe-YnReaZ... to l3c_b-vRr-o6ZFX_M... (flutter/engine#39055) (flutter/flutter#118968)

* f33e8d3 2a2dfaafb Roll Fuchsia Mac SDK from l7jVM3Urw73TVWfee... to 5TQ9IL4-Yu3KHCR-H... (flutter/engine#39056) (flutter/flutter#118969)
@nehalvpatel nehalvpatel self-requested a review January 31, 2023 23:54
Copy link
Contributor

@nehalvpatel nehalvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert Autorevert PR (with "Reason for revert:" comment)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants