-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Feat: showDatePicker
- Exposed callback when user changes Date Picker Mode
#119116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
showDatePicker
- Exposed callback when user changes entry mode (Calendar <=> Input )
showDatePicker
- Exposed callback when user changes entry mode (Calendar <=> Input )showDatePicker
- Exposed callback when user changes Date Picker Mode (Calendar <=> Input )
showDatePicker
- Exposed callback when user changes Date Picker Mode (Calendar <=> Input )showDatePicker
- Exposed callback when user changes Date Picker Mode
…nput mode, vice verca
…nput mode, vice verca
9a43820
to
a6b11da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just noted some small stuff.
Updated the API Doc
Updated the space in if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still really close. The presubmit analyze test is complaining about some trailing spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ate Picker Mode (flutter/flutter#119116)
…ate Picker Mode (flutter/flutter#119116)
…ate Picker Mode (flutter/flutter#119116)
Exposed a callback when the user switches between entry mode from calendar to input, this way we can store the preferred input method in the application state and open the next date picker with the preferred entry mode already set (using the existing
initialEntryMode
parameter).Fixes #113423
Example of callback
onDatePickerModeChange
Screen Recording
Screen.Recording.2023-01-25.at.11.53.51.AM.mov
CC: @Piinks , @HansMuller
Pre-launch Checklist
///
).