Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactoring to use ver command instead of systeminfo #119304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Jan 30, 2023
Merged

Refactoring to use ver command instead of systeminfo #119304

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f74a94f
refactoring to use `ver` command instead of `systeminfo`
eliasyishak Jan 27, 2023
d753dfb
fix tests to match new approach
eliasyishak Jan 27, 2023
5a55ce9
adding another valid validator using brazil locale text
eliasyishak Jan 27, 2023
53beb1a
refactor tests to use generic fake class `ver` arg + showing output f…
eliasyishak Jan 27, 2023
62dbad5
update reason text in test
eliasyishak Jan 30, 2023
82b7a28
fix reason text to be hard coded
eliasyishak Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding another valid validator using brazil locale text
  • Loading branch information
@eliasyishak
eliasyishak committed Jan 27, 2023
commit 5a55ce9f082947e6026bc4f693d2af1a315ae6f7
23 changes: 23 additions & 0 deletions packages/flutter_tools/test/general.shard/windows_version_validator_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ class FakeValidOperatingSystemUtils extends Fake
String get name => 'Microsoft Windows [Version 10.0.22621.963]';
}

/// A fake [_WindowsUtils] class for a valid version from Brazil
class FakeValidBrOperatingSystemUtils extends Fake
implements OperatingSystemUtils {
FakeValidBrOperatingSystemUtils();

@override
String get name => 'Microsoft Windows [versão 10.0.22621.1105]';
}

/// A fake [_WindowsUtils] class for a version that is not supported
class FakeInvalidOperatingSystemUtils extends Fake
implements OperatingSystemUtils {
Expand Down Expand Up @@ -58,6 +67,20 @@ void main() {
reason: 'The ValidationResult statusInfo messages should be the same');
});

testWithoutContext('Successfully running windows version check on windows 10 for BR',
() async {
final WindowsVersionValidator windowsVersionValidator =
WindowsVersionValidator(
operatingSystemUtils: FakeValidBrOperatingSystemUtils());

final ValidationResult result = await windowsVersionValidator.validate();

expect(result.type, validWindows10ValidationResult.type,
reason: 'The ValidationResult type should be the same (installed)');
expect(result.statusInfo, validWindows10ValidationResult.statusInfo,
reason: 'The ValidationResult statusInfo messages should be the same');
});

testWithoutContext('Identifying a windows version before 10', () async {
final WindowsVersionValidator windowsVersionValidator =
WindowsVersionValidator(
Expand Down