Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tool][web] Makes flutter.js more G3 friendly. #120504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 21, 2023
Merged

[tool][web] Makes flutter.js more G3 friendly. #120504

merged 5 commits into from
Feb 21, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Feb 11, 2023

Description

This PR makes the flutter.js loading process slightly more friendly with google's internal configuration by:

  • Relaxing the trusted types validation of the flutter loader, so files with different naming conventions can be used (both for the main.dart.js and flutter_service_worker.js files)
  • Nagging users less about the serviceWorker configuration being null.
    • Only prints a warning if serviceWorker is not available, and points users to Secure Context documentation if needed.
    • (Null configuration is still output as a low level debug.info message, which is often filtered out by browsers)

(FYI: @jacobsimionato)

Related issues

Fixes #120483
Fixes #116153

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from mdebbar February 11, 2023 00:46
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 11, 2023
mdebbar
mdebbar approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman
Copy link
Member Author

ditman commented Feb 11, 2023

LGTM!

Thanks for the super fast review @mdebbar, I'll autosubmit this on monday though :P

@ditman ditman added the e: flutter.js Issues with Flutter web custom initialization through JS APIs label Feb 11, 2023
@ditman ditman self-assigned this Feb 13, 2023
@ditman ditman force-pushed the make-flutterjs-more-g3-friendly branch from 75b0772 to b36832a Compare February 14, 2023 01:17
@ditman
Copy link
Member Author

ditman commented Feb 14, 2023 •
edited
Loading

It seems that the Google Testing check on this PR is failing because @mdebbar's reland PR hasn't relanded into G3 yet (cl/508823833?) Trying to rebase, see if the tests refresh, otherwise I might have to wait a few days until the Google roller catches up :/

@mdebbar
Copy link
Contributor

mdebbar commented Feb 17, 2023

@ditman my PR should've landed into g3 today. Please try again and see if it works now.

@ditman ditman force-pushed the make-flutterjs-more-g3-friendly branch from b36832a to caffbfe Compare February 18, 2023 02:28
@ditman
Copy link
Member Author

ditman commented Feb 18, 2023

(Rebased with the latest master)

@ditman
Copy link
Member Author

ditman commented Feb 18, 2023

The internal CL still has the wrong description, but the affected files now exactly match this PR, so I think the Google Testing step is going to work. Thanks @mdebbar!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 18, 2023

auto label is removed for flutter/flutter, pr: 120504, due to - The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@ditman
Copy link
Member Author

ditman commented Feb 21, 2023

Please, try again my dear bot.

@auto-submit auto-submit bot merged commit a463bb8 into flutter:master Feb 21, 2023
@ditman ditman deleted the make-flutterjs-more-g3-friendly branch February 21, 2023 21:21
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
a463bb82c [tool][web] Makes flutter.js more G3 friendly. (flutter/flu…
16d5e9b 
…tter#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
e44606b 
…er#120504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
e7bd9c2 
…er#120504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
9e0332c 
…er#120504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
d817da8 
…er#120504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
a777b55 
…er#120504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
7d6fa11 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
42f12d1 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
fe2e233 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
ce52cab 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
7a197fb 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
e6323f1 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
a2164b6 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
66e332b 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
0d581d8 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
827b0a5 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
881cfd1 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
e57077e 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
58a6d15 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
7dfa81f 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
e873b6b 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
2ccdcdf 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
5b372f8 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
1ca7e75 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
8eaaf96 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
037a9ae 
…er#120504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a463bb8 [tool][web] Makes flutter.js more G3 friendly. (flutter/flutt…
4ad6477 
…er#120504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees

@ditman ditman

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: flutter.js Issues with Flutter web custom initialization through JS APIs tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
2 participants
@ditman @mdebbar