Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Feb 17, 2023

Reverts #118577

This is breaking several places in the internal roll.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 17, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm assuming that if all pre-submit checks pass that nothing in the dart SDK or dds was migrated that now depends on this change :)

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2023
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad LGTM :(

@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 17, 2023

auto label is removed for flutter/flutter, pr: 120929, due to - The status or check suite Linux fuchsia_precache has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2023
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2023
@CaseyHillers CaseyHillers merged commit 298d8c7 into master Feb 17, 2023
@CaseyHillers CaseyHillers deleted the revert-118577-remove_observatory_messaging branch February 17, 2023 05:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 17, 2023
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Feb 17, 2023
* f85438bfa c8b1d2ffa Roll Fuchsia Mac SDK from YpQKlqmyn8r_snx06... to xl9Y8o-9FDyvPogki... (flutter/engine#39675) (flutter/flutter#120887)

* 174a562a6 d699b4a Roll Flutter from e3471f0 to df41e58f6f4e (83 revisions) (#7184) (flutter/flutter#120888)

* 170539f83 Roll Flutter Engine from c8b1d2ffaec8 to 0d8d93306822 (2 revisions) (flutter/flutter#120891)

* df98689c9 2be7253c9 Roll Fuchsia Linux SDK from q7u2WyX2BSRBIzyTW... to yT4JLKTCWWwbRwB0l... (flutter/engine#39679) (flutter/flutter#120898)

* cacef57b6 [flutter_tools] Skip over "Resolving dependencies..." text in integration tests (flutter/flutter#120077)

* 34102ca3b Migrate channels to pkg:integration _test (flutter/flutter#120833)

* df13ea248 Roll Flutter Engine from 2be7253c9b10 to e4cb80e22ee1 (2 revisions) (flutter/flutter#120903)

* a2e65f7c3 Roll Flutter Engine from e4cb80e22ee1 to 4a90fbcd6901 (2 revisions) (flutter/flutter#120911)

* e00241a06 Enable Windows plugin tests (flutter/flutter#119345)

* 09ad9f3cd Document ScrollPhysics invariant requiring ballistic motion (flutter/flutter#120400)

* 6029de2fb Update switch template (flutter/flutter#120919)

* 229d70ea3 Roll Flutter Engine from 4a90fbcd6901 to bddfc1c4dcaa (5 revisions) (flutter/flutter#120920)

* 206c6ae99 roll packages (flutter/flutter#120922)

* 9fcaaebb5 Roll Flutter Engine from bddfc1c4dcaa to 6602fc753525 (3 revisions) (flutter/flutter#120928)

* 00c0a07fa Increase Linux docs_test timeout (flutter/flutter#120899)

* e29a79975 946b29198 [dart:ui] Introduce `PlatformDispatcher.implicitView` (flutter/engine#39553) (flutter/flutter#120939)

* 081cd5776 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694) (flutter/flutter#120943)

* 875e48c69 52a4fb4c5 Roll Skia from b1800a8b9595 to d0df677ffd5e (13 revisions) (flutter/engine#39699) (flutter/flutter#120947)

* 78d058f46 6e92c0c28 Roll Fuchsia Mac SDK from xl9Y8o-9FDyvPogki... to haDvcC5VzWVdQs9Rs... (flutter/engine#39700) (flutter/flutter#120950)

* 298d8c76b Revert "Remove references to Observatory (#118577)" (flutter/flutter#120929)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 18, 2023
* df98689 2be7253c9 Roll Fuchsia Linux SDK from q7u2WyX2BSRBIzyTW... to yT4JLKTCWWwbRwB0l... (flutter/engine#39679) (flutter/flutter#120898)

* cacef57 [flutter_tools] Skip over "Resolving dependencies..." text in integration tests (flutter/flutter#120077)

* 34102ca Migrate channels to pkg:integration _test (flutter/flutter#120833)

* df13ea2 Roll Flutter Engine from 2be7253c9b10 to e4cb80e22ee1 (2 revisions) (flutter/flutter#120903)

* a2e65f7 Roll Flutter Engine from e4cb80e22ee1 to 4a90fbcd6901 (2 revisions) (flutter/flutter#120911)

* e00241a Enable Windows plugin tests (flutter/flutter#119345)

* 09ad9f3 Document ScrollPhysics invariant requiring ballistic motion (flutter/flutter#120400)

* 6029de2 Update switch template (flutter/flutter#120919)

* 229d70e Roll Flutter Engine from 4a90fbcd6901 to bddfc1c4dcaa (5 revisions) (flutter/flutter#120920)

* 206c6ae roll packages (flutter/flutter#120922)

* 9fcaaeb Roll Flutter Engine from bddfc1c4dcaa to 6602fc753525 (3 revisions) (flutter/flutter#120928)

* 00c0a07 Increase Linux docs_test timeout (flutter/flutter#120899)

* e29a799 946b29198 [dart:ui] Introduce `PlatformDispatcher.implicitView` (flutter/engine#39553) (flutter/flutter#120939)

* 081cd57 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694) (flutter/flutter#120943)

* 875e48c 52a4fb4c5 Roll Skia from b1800a8b9595 to d0df677ffd5e (13 revisions) (flutter/engine#39699) (flutter/flutter#120947)

* 78d058f 6e92c0c28 Roll Fuchsia Mac SDK from xl9Y8o-9FDyvPogki... to haDvcC5VzWVdQs9Rs... (flutter/engine#39700) (flutter/flutter#120950)

* 298d8c7 Revert "Remove references to Observatory (#118577)" (flutter/flutter#120929)

* 674254c Always use the testbed in web_test.dart so `environment` is populated. (flutter/flutter#120984)

* c4d40cc Modify the updateChildren method deep copy _children (flutter/flutter#120773)

* 9367641 clean up (flutter/flutter#120934)

* 51712b9 Roll Plugins from d699b4a91381 to 8f3419be5e0e (7 revisions) (flutter/flutter#120993)

* c3587c6 Add `InheritedTheme` support  to `ScrollbarTheme` (flutter/flutter#120970)

* 08b409a Roll Flutter Engine from 6e92c0c28410 to bd37a3992b50 (16 revisions) (flutter/flutter#121004)

* f785136 [web] Temporarily disable a line boundary test (flutter/flutter#121005)

* 9fe5567 Print sub process that failed to run in tool (flutter/flutter#120999)

* 6205c11 Remove "note that" in our documentation (as per style guide) (flutter/flutter#120842)

* 1daa0be Fix scrollable to clear inner semantics node if it does not use two p… (flutter/flutter#120996)

* 7f19b74 0a27673d7 Roll Skia from 02890036028e to 0e444e355607 (9 revisions) (flutter/engine#39723) (flutter/flutter#121008)

* 48d2dfc e7fde3f72 [web] Make glassPaneElement and glassPaneShadow non-nullable (flutter/engine#39692) (flutter/flutter#121009)

* 6104505 2b2780185 Roll Skia from 0e444e355607 to 4b79e398dfe0 (5 revisions) (flutter/engine#39725) (flutter/flutter#121016)

* f99f472 Remove the deprecated accentColor from ThemeData (flutter/flutter#120932)

* 2b4c960 Remove more references to dart:ui.window (flutter/flutter#120994)

* 0fa6527 Roll Flutter Engine from 2b2780185dd5 to a37e27b77008 (2 revisions) (flutter/flutter#121020)

* 9281114 Roll Flutter Engine from a37e27b77008 to 2fdce9a96367 (2 revisions) (flutter/flutter#121023)

* 4dd555d Roll Flutter Engine from 2fdce9a96367 to 9a3c3e462fce (3 revisions) (flutter/flutter#121025)

* 66dce65 Roll Flutter Engine from 9a3c3e462fce to 3777ed51774f (2 revisions) (flutter/flutter#121029)

* a5b53a6 a9db42c3e Roll Skia from 733a19f6a625 to 2f05923f825e (3 revisions) (flutter/engine#39744) (flutter/flutter#121030)

* 0be7c3f Roll Flutter Engine from a9db42c3edc2 to c22c64812243 (2 revisions) (flutter/flutter#121041)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
waegari pushed a commit to waegari/flutter_plugins that referenced this pull request Jul 3, 2025
…r#7190)

* f85438bfa c8b1d2ffa Roll Fuchsia Mac SDK from YpQKlqmyn8r_snx06... to xl9Y8o-9FDyvPogki... (flutter/engine#39675) (flutter/flutter#120887)

* 174a562a6 d699b4a Roll Flutter from e3471f0 to df41e58f6f4e (83 revisions) (flutter#7184) (flutter/flutter#120888)

* 170539f83 Roll Flutter Engine from c8b1d2ffaec8 to 0d8d93306822 (2 revisions) (flutter/flutter#120891)

* df98689c9 2be7253c9 Roll Fuchsia Linux SDK from q7u2WyX2BSRBIzyTW... to yT4JLKTCWWwbRwB0l... (flutter/engine#39679) (flutter/flutter#120898)

* cacef57b6 [flutter_tools] Skip over "Resolving dependencies..." text in integration tests (flutter/flutter#120077)

* 34102ca3b Migrate channels to pkg:integration _test (flutter/flutter#120833)

* df13ea248 Roll Flutter Engine from 2be7253c9b10 to e4cb80e22ee1 (2 revisions) (flutter/flutter#120903)

* a2e65f7c3 Roll Flutter Engine from e4cb80e22ee1 to 4a90fbcd6901 (2 revisions) (flutter/flutter#120911)

* e00241a06 Enable Windows plugin tests (flutter/flutter#119345)

* 09ad9f3cd Document ScrollPhysics invariant requiring ballistic motion (flutter/flutter#120400)

* 6029de2fb Update switch template (flutter/flutter#120919)

* 229d70ea3 Roll Flutter Engine from 4a90fbcd6901 to bddfc1c4dcaa (5 revisions) (flutter/flutter#120920)

* 206c6ae99 roll packages (flutter/flutter#120922)

* 9fcaaebb5 Roll Flutter Engine from bddfc1c4dcaa to 6602fc753525 (3 revisions) (flutter/flutter#120928)

* 00c0a07fa Increase Linux docs_test timeout (flutter/flutter#120899)

* e29a79975 946b29198 [dart:ui] Introduce `PlatformDispatcher.implicitView` (flutter/engine#39553) (flutter/flutter#120939)

* 081cd5776 650db7a72 [macOS] Eliminate mirrors support (flutter/engine#39694) (flutter/flutter#120943)

* 875e48c69 52a4fb4c5 Roll Skia from b1800a8b9595 to d0df677ffd5e (13 revisions) (flutter/engine#39699) (flutter/flutter#120947)

* 78d058f46 6e92c0c28 Roll Fuchsia Mac SDK from xl9Y8o-9FDyvPogki... to haDvcC5VzWVdQs9Rs... (flutter/engine#39700) (flutter/flutter#120950)

* 298d8c76b Revert "Remove references to Observatory (#118577)" (flutter/flutter#120929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants