-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Deprecate BindingBase.window #120998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate BindingBase.window #120998
Conversation
@pdblasi-google This is my suggestion for the deprecation message on |
0f2847f
to
f66fc71
Compare
d109cfc
to
f0e08e3
Compare
/// If a [BuildContext] is available, consider looking up the current | ||
/// [FlutterView] associated with that context via [View.of]. It gives access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider:
/// If a [BuildContext] is available, consider looking up the current | |
/// [FlutterView] associated with that context via [View.of]. It gives access | |
/// If a [BuildContext] is available, you can get the context's | |
/// current [FlutterView] via [View.of]. It gives access |
I don't feel strongly about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am gonna leave this as-is since our style guide doesn't like to use the word "you": https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#use-the-passive-voice-recommend-do-not-require-never-say-things-are-simple
/// to the same functionality as this deprecated property. However, some | ||
/// functionality has moved to the [PlatformDispatcher], which should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the language you use below in the See also section:
/// to the same functionality as this deprecated property. However, some | |
/// functionality has moved to the [PlatformDispatcher], which should be | |
/// to the same functionality as this deprecated property. The | |
/// platform-specific functionality has moved .... |
I don't feel strongly about this
/// property. | ||
/// | ||
/// If no context is available to look up a [FlutterView], the | ||
/// [platformDispatcher] exposed by this binding can be consulted directly for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider simpler language for non-native speakers:
/// [platformDispatcher] exposed by this binding can be consulted directly for | |
/// [platformDispatcher] exposed by this binding can be used directly for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f0e08e3
to
4d23cf2
Compare
4d23cf2
to
c107892
Compare
Part of #116929.
Migration Guide: flutter/website#8283
Also adds ignores required for flutter/engine#39302.
To be submitted after deprecations for
flutter_test
.