-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Remove accessibleNavigation reference from BottomSheet #121132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove accessibleNavigation reference from BottomSheet #121132
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This looks like an ok change to make, I did some digging and found #32528 added this, but those tests were changed soon after for #42404 We can certainly run it through additional testing to be sure though. :) |
@Piinks Thanks for the feedback! Should I remove the [WIP] in title to make it possible to run this PR on additional testing? |
e2b30a2
to
20dbb0d
Compare
No need, it was pretty easy for me to just go run this one since the actual change is simple. I will report back with results! |
All of the tests passed. This is safe to proceed! :) |
20dbb0d
to
3ee0ec0
Compare
3ee0ec0
to
6b49a54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR removes
MediaQueryData.accessibleNavigation
usage fromModalBottomSheet
.See #121098 for motivation.
It is a WIP PR because this removal needs more insights. No test are broken but there might be a missing one.Related Issue
Fixes #121098
Fixes #119094
Tests
Add 1 regression test.