Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove accessibleNavigation reference from BottomSheet #121132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Feb 21, 2023

Description

This PR removes MediaQueryData.accessibleNavigation usage from ModalBottomSheet.
See #121098 for motivation.

It is a WIP PR because this removal needs more insights. No test are broken but there might be a missing one.

Related Issue

Fixes #121098
Fixes #119094

Tests

Add 1 regression test.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 21, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks
Copy link
Contributor

Piinks commented Feb 22, 2023

This looks like an ok change to make, I did some digging and found #32528 added this, but those tests were changed soon after for #42404
The point you make in #121098 is valid, it does not seem congruent with how accessible navigation is used elsewhere in the framework, and it may in fact have been a workaround for the issue fixed by flutter/engine#35478

We can certainly run it through additional testing to be sure though. :)

@bleroux
Copy link
Contributor Author

bleroux commented Feb 23, 2023

@Piinks Thanks for the feedback! Should I remove the [WIP] in title to make it possible to run this PR on additional testing?

@bleroux bleroux force-pushed the fix_remove_accessibleNavigation_usage_in_BottomSheet branch from e2b30a2 to 20dbb0d Compare February 23, 2023 15:47
@Piinks
Copy link
Contributor

Piinks commented Feb 23, 2023

No need, it was pretty easy for me to just go run this one since the actual change is simple. I will report back with results!

@Piinks
Copy link
Contributor

Piinks commented Feb 23, 2023

All of the tests passed. This is safe to proceed! :)

@bleroux bleroux changed the title [WIP] Remove accessibleNavigation reference from BottomSheet Remove accessibleNavigation reference from BottomSheet Feb 24, 2023
@bleroux bleroux force-pushed the fix_remove_accessibleNavigation_usage_in_BottomSheet branch from 20dbb0d to 3ee0ec0 Compare February 24, 2023 09:37
@bleroux bleroux force-pushed the fix_remove_accessibleNavigation_usage_in_BottomSheet branch from 3ee0ec0 to 6b49a54 Compare February 24, 2023 09:39
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2023
@auto-submit auto-submit bot merged commit 5d99748 into flutter:master Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@bleroux bleroux deleted the fix_remove_accessibleNavigation_usage_in_BottomSheet branch February 24, 2023 17:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
2 participants