Fix AppBar scrolled under for 2D scrolling #121297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like there are some test failures in Google that may actually be bugs this change would fix. Need to confirm with the customer first. |
0ebccb7 to
3082b3d
Compare
|
Th g3 testing shard is having issues again. Verified with the customers that the test failures that were found are ok to proceed. Rebased to try to kick the bots so this can land. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121296
2D Scrolling proposal: flutter.dev/go/2D-Foundation
In preparation for 2D scrolling, this removes an assumption that any horizontal scrolling notification that passes the predicate should clear the scrolled under status. In 2D, both axes will pass the default predicate.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.