Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update scroll paging logic in Scrollbar #121481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2023
Merged

Update scroll paging logic in Scrollbar #121481

merged 2 commits into from
Feb 27, 2023

Conversation

taniyarn
Copy link
Contributor

@taniyarn taniyarn commented Feb 26, 2023 •
edited by Piinks
Loading

Fixes #112893.
By using the newly exposed methods in RawScrollbar, we can remove the duplicated code.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Feb 26, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Feb 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@taniyarn taniyarn mentioned this pull request Feb 26, 2023
Closed
@Hixie
Copy link
Contributor

Hixie commented Feb 26, 2023

test-exempt: code refactor with no semantic change

@Piinks Piinks self-requested a review February 27, 2023 18:05
@Piinks Piinks added the c: tech-debt Technical debt, code quality, testing, etc. label Feb 27, 2023
Piinks
Piinks approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, welcome! And thanks for the contribution!

@Piinks
Copy link
Contributor

Piinks commented Feb 27, 2023

This will need a second review, I will seek one out.

jonahwilliams
jonahwilliams approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot merged commit 6175937 into flutter:master Feb 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
6175937 Update scroll paging logic in Scrollbar (flutter/flutter#121481)
d914437
@HansMuller HansMuller mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6175937 Update scroll paging logic in Scrollbar (flutter/flutter#121481)
6adfa9a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6175937 Update scroll paging logic in Scrollbar (flutter/flutter#121481)
5a9fbb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: tech-debt Technical debt, code quality, testing, etc. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update scroll paging logic in Scrollbar
4 participants
@taniyarn @Hixie @Piinks @jonahwilliams