Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[conductor] Roll engine whenever version is out of date #121502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2023
Merged

[conductor] Roll engine whenever version is out of date #121502

merged 2 commits into from
Mar 3, 2023

Conversation

CaseyHillers
Copy link
Contributor

Fixes #121234

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

[conductor] Roll engine->flutter whenever version is out of date
534887a 
* Previous logic only did it when CPs were passeed
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 27, 2023
@CaseyHillers CaseyHillers marked this pull request as ready for review February 27, 2023 04:39
christopherfujino
christopherfujino reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, I'll leave it to @itsjustkevin for final approval however, as I already approved #121403 which also looks correct.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit auto-submit bot merged commit 22e3327 into flutter:master Mar 3, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2023
@engine-flutter-autoroll
22e3327 [conductor] Roll engine->flutter whenever version is out of d…
6dcca2c 
…ate (flutter/flutter#121502)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
22e3327 [conductor] Roll engine->flutter whenever version is out of d…
d6de799 
…ate (flutter/flutter#121502)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
22e3327 [conductor] Roll engine->flutter whenever version is out of d…
3747ffd 
…ate (flutter/flutter#121502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino left review comments

@itsjustkevin itsjustkevin itsjustkevin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[conductor] Framework PR is not generated when engine has no dart-revision.
3 participants
@CaseyHillers @christopherfujino @itsjustkevin