Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Print on failure in web hotrestart tests #122115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2023
Merged

Print on failure in web hotrestart tests #122115

merged 3 commits into from
Mar 7, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Mar 7, 2023

Print on failure in web hot restart tests to debug the flake in #121708

This is a test-only change.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 7, 2023
ditman
ditman approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is flutter.stderr a thing that may be interesting too?

christopherfujino
christopherfujino approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@annagrin annagrin merged commit d76860a into flutter:master Mar 7, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
d76860a Add printing on failure to web hotrestart tests (flutter/flut…
cee9679 
…ter#122115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
d76860a Add printing on failure to web hotrestart tests (flutter/flut…
d5132ed 
…ter#122115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
@engine-flutter-autoroll
d76860a Add printing on failure to web hotrestart tests (flutter/flut…
3526c12 
…ter#122115)
@cyanglaz cyanglaz mentioned this pull request Mar 8, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2023
Closed
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@hannah-hyj
Add printing on failure to web hotrestart tests (flutter#122115)
ad7f3c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d76860a Add printing on failure to web hotrestart tests (flutter/flut…
d5db837 
…ter#122115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d76860a Add printing on failure to web hotrestart tests (flutter/flut…
fcb2129 
…ter#122115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annagrin @ditman @christopherfujino