Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clear _scribbleCacheKey when connection closes #122145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

Clear _scribbleCacheKey when connection closes #122145

merged 1 commit into from
Mar 8, 2023

Conversation

moffatman
Copy link
Contributor

When a TextInputConnection is recreated in the engine, it won't have its previous selectionRects remembered. But the framework still thinks it does, as _scribbleCacheKey isn't changed. The effect of this is that when refocusing a text field, the selectionRects will be missing until the text is changed. By clearing the cache-key, they will be properly re-sent when the TextInputConnection is re-opened.

Part of #30476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2023
@moffatman moffatman mentioned this pull request Mar 7, 2023
Merged
8 tasks
@moffatman moffatman force-pushed the selection_rects_cache branch from fbfca25 to 5927d4c Compare March 7, 2023 23:35
LongCatIsLooong
LongCatIsLooong approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@moffatman moffatman force-pushed the selection_rects_cache branch from 5927d4c to 236c7bb Compare March 8, 2023 13:40
@auto-submit auto-submit bot merged commit 1ab3cb9 into flutter:master Mar 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
e6b91fa 
…er#122145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
214e749 
…er#122145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
eef0180 
…er#122145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
c56fee3 
…er#122145)
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@moffatman @hannah-hyj
Clear _scribbleCacheKey when connection closes (flutter#122145)
b818992 
Clear _scribbleCacheKey when connection closes
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
81510c8 
…er#122145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
d434cad 
…er#122145)
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
96f4ff2 
…er#122145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
1ab3cb9 Clear _scribbleCacheKey when connection closes (flutter/flutt…
f3623fb 
…er#122145)
@hellohuanlin
Copy link
Contributor

When a TextInputConnection is recreated in the engine, it won't have its previous selectionRects remembered.

Noob question: Is the connection created every time a text input is focused? @moffatman

@moffatman
Copy link
Contributor Author

@hellohuanlin It might be, not actually sure. This fixes the issue observed when you tested in the dev/integration_tests/ios_platform_view_tests. So it is at minimum re-created when switching from a non-flutter UITextField. I didn't notice it myself in my own tests, but I can't remember if I tried switching between multiple fields before this fix.

@hellohuanlin
Copy link
Contributor

^ @LongCatIsLooong i'm wondering if you have context on question? Thanks!

@LongCatIsLooong
Copy link
Contributor

Yeah whenever an input field gains focus it creates a connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moffatman @hellohuanlin @LongCatIsLooong