Stocks has both tabs reified in the wiget tree #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were recomputing which widgets to show only when we were on the other side of the repaint boundaries. That doesn't work well for pageable lists because we come to rest exactly on a repaint boundary, which means we don't cull the other page. After this patch, we recompute the set of widgets using an edge-trigger when we hit the boundary. That's better than using a level-trigger so that we don't continuously recompute the set of widget as we sit at the boundary.
| @@ -225,10 +225,10 @@ class _PageViewportElement extends VirtualViewportElement<PageViewport> { | |||
| return -(widget.startOffset - startOffsetBase) * _containerExtent; | |||
| } | |||
|
|
|||
| void updateRenderObject() { | |||
| void updateRenderObject(PageViewport oldWidget) { | |||
There was a problem hiding this comment.
!!! Oh, nevermind. I see now that you are changing this API signature. I thought you had just found places that didn't have the right signature.
There was a problem hiding this comment.
Yeah, I just made this instance of this pattern match the one we use elsewhere.
|
LGTM |
abarth
added a commit
that referenced
this pull request
Jan 14, 2016
Stocks has both tabs reified in the wiget tree
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were recomputing which widgets to show only when we were on the other side
of the repaint boundaries. That doesn't work well for pageable lists because we
come to rest exactly on a repaint boundary, which means we don't cull the other
page.
After this patch, we recompute the set of widgets using an edge-trigger when we
hit the boundary. That's better than using a level-trigger so that we don't
continuously recompute the set of widget as we sit at the boundary.