Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix SliverReorderableList test to use correct custom action id #125144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix SliverReorderableList test to use correct custom action id #125144

merged 1 commit into from
Apr 19, 2023

Conversation

chunhtai
Copy link
Contributor

as title

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 19, 2023
@chunhtai chunhtai requested review from goderbauer and zanderso April 19, 2023 17:04
@chunhtai
Copy link
Contributor Author

This pr would need to be land on red to unblock the tree

zanderso
zanderso approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@chunhtai chunhtai added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Apr 19, 2023
@chunhtai chunhtai mentioned this pull request Apr 19, 2023
Merged
8 tasks
@justinmc justinmc mentioned this pull request Apr 19, 2023
Merged
@chunhtai
Copy link
Contributor Author

ci should be good enough, the pending one is unrelated merging now

@chunhtai chunhtai merged commit 122dacf into flutter:master Apr 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
ebc1cb0 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
41c4c55 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
dae6e0a 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
df4afed 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
af2c4df 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
c2fb9fb 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
e077e50 
flutter/flutter#125144)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
74ec6db 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
cd76ad3 
flutter/flutter#125144)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
6455b54 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
cd64920 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
3349cc2 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
82444f9 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
503963c 
flutter/flutter#125144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
2e0591c 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
20b98f9 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
98eb90b 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
4e74bf8 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
16959b6 
flutter/flutter#125144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
122dacf fix SliverReorderableList test to use correct custom action id (
976eef9 
flutter/flutter#125144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunhtai @zanderso