Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the divider_theme space documentation problem #125195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix the divider_theme space documentation problem #125195

merged 1 commit into from
Apr 21, 2023

Conversation

xcc3641
Copy link
Contributor

@xcc3641 xcc3641 commented Apr 20, 2023 •
edited
Loading

In the specific implementation, the Divider uses the "space" field as the height for horizontal dividers, and the "space" field as the width for VerticalDivider , which is different from the documentation description.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 20, 2023
@google-cla
Copy link

google-cla bot commented Apr 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@HansMuller HansMuller requested a review from gspencergoog April 21, 2023 21:44
gspencergoog
gspencergoog approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for fixing that!

@gspencergoog
Copy link
Contributor

gspencergoog commented Apr 21, 2023 •
edited
Loading

@xcc3641 Thanks for the PR! Before we can continue, though, you'll need to accept the CLA, as the notice from the bot above says.

EDIT: Nevermind, I see you've signed it.

QuncCccccc
QuncCccccc approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot merged commit d93ffc1 into flutter:master Apr 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
50d3c4b 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
4052422 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
ec1bbad 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
bf1f3ce 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
19c1754 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
dab7da7 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
2c3a042 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
361dda5 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
2fcd53a 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
5d10165 
…utter#125195)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
b53c718 
…utter#125195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
f4f691e 
…utter#125195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
baa044c 
…utter#125195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
d93ffc1 Fix the divider_theme space documentation problem (flutter/fl…
86c61a5 
…utter#125195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xcc3641 @gspencergoog @QuncCccccc