Cherry Pick Spell Check Fixes #125517
Merged
Cherry Pick Spell Check Fixes #125517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Localize the 'No Replacements Found' spell check string
Fixes the cursor location after selecting a spell check result on iOS.
Tidying up the spell check API.
…4899) Fixes a bug where the spell check menu could overflow.
Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.
iOS now hides the selection handles and shows red selection when tapping a misspelled word, like native.
…4897) The spell check menu now appears directly below the misspelled word on Android.
When using a Material TextField on iOS, the spell check selection style now defaults to the red iOS-style, not Android's blue.
itsjustkevin
approved these changes
Apr 26, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick of 8 of my recent spell check bug fixes into the beta branch.
This is the behavior of spell check with these changes:
Screen.Recording.2023-04-24.at.11.44.23.AM.mov
CC @itsjustkevin @leighajarett