Add option for flexible space on material SearchDelegate #128132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egate class introduce the option for add a flexibleSpace Widget to AppBar in a _SearchPage
…hDelegate and SearchPage classes
goderbauer
reviewed
Jun 12, 2023
| /// See also: | ||
| /// | ||
| /// * [AppBar.flexibleSpace], the intended use for the return value of this method. | ||
| /// |
| @@ -211,6 +211,16 @@ abstract class SearchDelegate<T> { | |||
| /// | |||
| PreferredSizeWidget? buildBottom(BuildContext context) => null; | |||
|
|
|||
| /// Widget to display in the [AppBar] flexible space. | |||
There was a problem hiding this comment.
Maybe just:
Suggested change
| /// Widget to display in the [AppBar] flexible space. | |
| /// Widget to display in the [AppBar.flexibleSpace]. |
and then remove the "see also" section?
There was a problem hiding this comment.
I did this way to keep the pattern of others documentation for build methods in the class.
You can see it in PreferredSizeWidget? buildBottom(BuildContext) and List<Widget>? buildActions(BuildContext).
my changes sounds better ?
/// Widget to display a flexible space in the [AppBar].
///
/// Returns null by default, i.e. a flexible space widget is not included.
///
/// See also:
///
/// * [AppBar.flexibleSpace], the intended use for the return value of this method.
Widget? buildFlexibleSpace(BuildContext context) => null;
Comment on lines
1115
to
1116
| // @override | ||
| // Widget? buildFlexibleSpace(BuildContext context) => null; |
| @@ -980,6 +1006,7 @@ class _TestSearchDelegate extends SearchDelegate<String> { | |||
| this.suggestions = 'Suggestions', | |||
| this.result = 'Result', | |||
| this.actions = const <Widget>[], | |||
| this.flexibleSpace = const Text('FlexibleSpace'), | |||
There was a problem hiding this comment.
make this null by default so this change doesn't invalidate all the other tests and make sure everything still works without this set? Then, add specific tests that set this to non-null and check that everything works.
set flexibleSpace parameter default value as null (_TestSearchDelegate material search test)
|
Hey @goderbauer, I think I did everything that was needed here. |
|
auto label is removed for flutter/flutter, pr: 128132, due to - The status or check suite Windows build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 7, 2023
flutter/flutter@bc49cd1...d55a7d8 2023-07-07 [email protected] Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144) 2023-07-07 [email protected] Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (flutter/flutter#130143) 2023-07-07 [email protected] Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116) 2023-07-07 [email protected] Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114) 2023-07-07 [email protected] Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110) 2023-07-07 [email protected] Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107) 2023-07-06 [email protected] Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106) 2023-07-06 [email protected] Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050) 2023-07-06 [email protected] Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100) 2023-07-06 [email protected] Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097) 2023-07-06 [email protected] Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398) 2023-07-06 [email protected] Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962) 2023-07-06 [email protected] [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776) 2023-07-06 [email protected] Add option for flexible space on material SearchDelegate (flutter/flutter#128132) 2023-07-06 [email protected] Roll Packages from 7042079 to 771ec9b (12 revisions) (flutter/flutter#130077) 2023-07-06 [email protected] [framework] Add textField OCR support for framework side (flutter/flutter#96637) 2023-07-06 [email protected] [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
buildFlexibleSpacemethod to theSearchDelegateclass in the material library.It allows users to add a flexible space widget to the
AppBarin a_SearchPage, providing more customization options.This PR does not fix any specific issue as there are no open issues related to this feature.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.