Scaffold should respect window.padding.bottom #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. iOS does not communicate the bottom padding to the dart side currently. I will look into using |
|
Thanks. I can also look into the iOS side. I need to tech up on that. |
The space for the keyboard is now represented as bottom padding for the window. By teaching the scaffold to respect the bottom window padding, we move the floating action button and snackbars out of the way of the keyboard. This currently works on Android. I'll need to see how to get the keyboard geometry on iOS for a similar effect. Fixes flutter#103
4e4f288 to
da7e1e5
Compare
abarth
added a commit
that referenced
this pull request
Jan 21, 2016
Scaffold should respect window.padding.bottom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space for the keyboard is now represented as bottom padding for the window.
By teaching the scaffold to respect the bottom window padding, we move the
floating action button and snackbars out of the way of the keyboard.
This currently works on Android. I'll need to see how to get the keyboard
geometry on iOS for a similar effect.
Fixes #103