Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134493

vashworth · 2023-09-12T02:25:54Z

Xcode uses the CONFIGURATION_BUILD_DIR build setting to determine the location of the bundle to build and install. When launching an app via Xcode with the Xcode debug workflow (for iOS 17 physical devices), temporarily set the CONFIGURATION_BUILD_DIR to the location of the bundle so Xcode can find it.

Also, added a Xcode Debug version of the microbenchmarks_ios integration test since it uses flutter run --profile without using --use-application-binary.

Fixes #134186.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dev/devicelab/bin/tasks/microbenchmarks_ios_xcode_debug.dart

christopherfujino · 2023-09-12T17:42:44Z

dev/devicelab/lib/microbenchmarks.dart

+
+      // Give the process a couple of seconds to exit and run shutdown hooks
+      // before sending kill signal.
+      await Future<void>.delayed(const Duration(seconds: 2));


has this been an issue, or are you adding this just in case?

actually, reading the comment from lines 61-64, I actually fixed that in #99871.

Were there particular shutdown hooks you were concerned about?

It was an issue when I ran the test locally because the shutdown hook which kills Xcode wasn't being triggered because the kill signal was sent before the q input could even be processed.

I don't know if it's been an issue in the past

This is the shutdown hook I was having issues with: https://github.com/vashworth/flutter/blob/master/packages/flutter_tools/lib/src/ios/devices.dart#L868-L871

so actually, do we run the shutdownHooks when we send q? Let me check.

Yes, shutdown hooks are run when we send q.

It seems like shutdown hooks aren't run when you send a sigint kill signal

well, this would be a serious bug, but anyway, this is fine as is for now, i'll file a tracking issue for us not handling SIGINT correctly.

dev/devicelab/lib/microbenchmarks.dart

christopherfujino

lgtm

christopherfujino

still lgtm

XilaiZhang · 2023-09-12T22:51:02Z

ok great i redeployed frob and Google Testing is now propagating the correct information on merge conflict

auto-submit · 2023-09-13T18:01:56Z

auto label is removed for flutter/flutter/134493, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…bugging core device (flutter/flutter#134493)

…_xcode_debug test (#134693) Test added in #134493 requires an older version of Xcode because default version of Xcode is not compatible with macOS version in CI. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

flutter/flutter@61b890b...58ba6c2 2023-09-14 [email protected] Roll Packages from 06cd9e9 to 275b76c (1 revision) (flutter/flutter#134734) 2023-09-14 [email protected] Update plugin_ffi generated file to match FFIgen 9.0.0 (flutter/flutter#134614) 2023-09-14 [email protected] LinkedText (Linkify) (flutter/flutter#125927) 2023-09-14 [email protected] _DayPicker should build days using separate stetefull widget _Day. (flutter/flutter#134607) 2023-09-13 [email protected] Remove `Path.combine` call from `CupertionoTextSelectionToolbar` (flutter/flutter#134369) 2023-09-13 [email protected] Update KeepAlive.debugTypicalAncestorWidgetClass (flutter/flutter#133498) 2023-09-13 [email protected] Fix null check crash by ReorderableList (flutter/flutter#132153) 2023-09-13 [email protected] Roll Flutter Engine from 154d6fd601a3 to cd90cc8469fb (3 revisions) (flutter/flutter#134691) 2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/flutter#134692) 2023-09-13 [email protected] Roll Flutter Engine from b71b366e3de3 to 154d6fd601a3 (6 revisions) (flutter/flutter#134683) 2023-09-13 [email protected] [flutter_tools] Run ShutdownHooks when handling signals (flutter/flutter#134590) 2023-09-13 [email protected] Dispose routes in navigator when throwing exception (flutter/flutter#134596) 2023-09-13 [email protected] [framework] reduce ink sparkle uniform count. (flutter/flutter#133897) 2023-09-13 [email protected] Roll Flutter Engine from 5e671d5c90f9 to b71b366e3de3 (4 revisions) (flutter/flutter#134676) 2023-09-13 [email protected] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device (flutter/flutter#134493) 2023-09-13 [email protected] Bump gradle heap size limit in *everywhere* (flutter/flutter#134665) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…core device (flutter#134493) Xcode uses the CONFIGURATION_BUILD_DIR build setting to determine the location of the bundle to build and install. When launching an app via Xcode with the Xcode debug workflow (for iOS 17 physical devices), temporarily set the CONFIGURATION_BUILD_DIR to the location of the bundle so Xcode can find it. Also, added a Xcode Debug version of the `microbenchmarks_ios` integration test since it uses `flutter run --profile` without using `--use-application-binary`. Fixes flutter#134186.

…debugging core device (#134824) Original PR: #134493

…ging core device (#134835) Original PR: #134493

…core device (flutter#134493) Xcode uses the CONFIGURATION_BUILD_DIR build setting to determine the location of the bundle to build and install. When launching an app via Xcode with the Xcode debug workflow (for iOS 17 physical devices), temporarily set the CONFIGURATION_BUILD_DIR to the location of the bundle so Xcode can find it. Also, added a Xcode Debug version of the `microbenchmarks_ios` integration test since it uses `flutter run --profile` without using `--use-application-binary`. Fixes flutter#134186.

…_xcode_debug test (flutter#134693) Test added in flutter#134493 requires an older version of Xcode because default version of Xcode is not compatible with macOS version in CI. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…bugging core device (flutter/flutter#134493)

vashworth added 3 commits September 11, 2023 19:26

set the CONFIGURATION in generated xcconfig when debugging core device

9bb1294

remove print line

d8a95d5

use CONFIGURATION_BUILD_DIR instead

5a19e66

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 12, 2023

vashworth changed the title ~~Set the CONFIGURATION in generated xcconfig when debugging core device~~ Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device Sep 12, 2023

vashworth and others added 2 commits September 12, 2023 08:44

add test ownership

5a1a9d2

Merge branch 'master' into ios_17_profile_mode

e6f3c6c

vashworth requested a review from christopherfujino September 12, 2023 16:20

christopherfujino reviewed Sep 12, 2023

View reviewed changes

dev/devicelab/bin/tasks/microbenchmarks_ios_xcode_debug.dart Outdated Show resolved Hide resolved

christopherfujino reviewed Sep 12, 2023

View reviewed changes

dev/devicelab/lib/microbenchmarks.dart Show resolved Hide resolved

christopherfujino approved these changes Sep 12, 2023

View reviewed changes

add/move TODOs

d111a97

christopherfujino approved these changes Sep 12, 2023

View reviewed changes

vashworth mentioned this pull request Sep 13, 2023

Google testing failure missing triage info #134668

Closed

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023

XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023

auto-submit bot merged commit af5ac93 into flutter:master Sep 13, 2023

christopherfujino mentioned this pull request Sep 13, 2023

GitHub check for Google testing sometimes reverts to red after having been manually overridden to green #134684

Closed

vashworth mentioned this pull request Sep 13, 2023

Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test #134693

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Sep 14, 2023

Roll Flutter from 61b890bfcbc1 to 58ba6c295d8c (16 revisions) flutter/packages#4928

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2023

af5ac93 Set the CONFIGURATION_BUILD_DIR in generated xcconfig when de…

35a0685

…bugging core device (flutter/flutter#134493)

vashworth mentioned this pull request Sep 15, 2023

[CP 3.13] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134824

Merged

8 tasks

vashworth mentioned this pull request Sep 15, 2023

[CP 3.14] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134826

Closed

8 tasks

vashworth mentioned this pull request Sep 15, 2023

[CP] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134835

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Sep 15, 2023

[CP 3.13] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when …

0776843

…debugging core device (#134824) Original PR: #134493

auto-submit bot pushed a commit that referenced this pull request Sep 18, 2023

[CP] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debug…

158598a

…ging core device (#134835) Original PR: #134493

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

af5ac93 Set the CONFIGURATION_BUILD_DIR in generated xcconfig when de…

1a500f5

…bugging core device (flutter/flutter#134493)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134493

Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134493

vashworth commented Sep 12, 2023 •

edited

Loading

christopherfujino Sep 12, 2023

christopherfujino Sep 12, 2023

vashworth Sep 12, 2023

vashworth Sep 12, 2023

christopherfujino Sep 12, 2023

vashworth Sep 12, 2023

christopherfujino Sep 12, 2023

christopherfujino left a comment

christopherfujino left a comment

XilaiZhang commented Sep 12, 2023

auto-submit bot commented Sep 13, 2023

Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134493

Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device #134493

Conversation

vashworth commented Sep 12, 2023 • edited Loading

Pre-launch Checklist

christopherfujino Sep 12, 2023

Choose a reason for hiding this comment

christopherfujino Sep 12, 2023

Choose a reason for hiding this comment

vashworth Sep 12, 2023

Choose a reason for hiding this comment

vashworth Sep 12, 2023

Choose a reason for hiding this comment

christopherfujino Sep 12, 2023

Choose a reason for hiding this comment

vashworth Sep 12, 2023

Choose a reason for hiding this comment

christopherfujino Sep 12, 2023

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

XilaiZhang commented Sep 12, 2023

auto-submit bot commented Sep 13, 2023

vashworth commented Sep 12, 2023 •

edited

Loading