-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test #134693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vashworth
merged 1 commit into
flutter:master
from
vashworth:fix_microbenchmarks_ios_xcode_debug
Sep 14, 2023
Merged
Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test #134693
vashworth
merged 1 commit into
flutter:master
from
vashworth:fix_microbenchmarks_ios_xcode_debug
Sep 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherfujino
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/flutter/134693, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 15, 2023
…arks_ios_xcode_debug test (flutter/flutter#134693)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 15, 2023
…arks_ios_xcode_debug test (flutter/flutter#134693)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 15, 2023
…arks_ios_xcode_debug test (flutter/flutter#134693)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 15, 2023
flutter/flutter@58ba6c2...72b69f9 2023-09-15 [email protected] Date picker dialog state should dispose members. (flutter/flutter#134804) 2023-09-15 [email protected] Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823) 2023-09-15 [email protected] Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815) 2023-09-15 [email protected] Applied the logo to the Discord badge. (flutter/flutter#134339) 2023-09-15 [email protected] Fix memory leak in ListWheelScrollView (flutter/flutter#134732) 2023-09-15 [email protected] Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784) 2023-09-14 [email protected] Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789) 2023-09-14 [email protected] [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240) 2023-09-14 [email protected] Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778) 2023-09-14 [email protected] Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769) 2023-09-14 [email protected] Allows page removal that contains Localhistoryentry (flutter/flutter#134757) 2023-09-14 [email protected] Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763) 2023-09-14 [email protected] Cover more test/widgets tests with leak tracking #3 (flutter/flutter#134576) 2023-09-14 [email protected] Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755) 2023-09-14 [email protected] Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693) 2023-09-14 [email protected] Cover some Services tests with leak tracing (flutter/flutter#134381) 2023-09-14 [email protected] Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749) 2023-09-14 [email protected] � Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492) 2023-09-14 [email protected] Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719) 2023-09-14 [email protected] Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695) 2023-09-14 [email protected] Added a devicelab test for vulkan validation layers (flutter/flutter#134685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…_xcode_debug test (flutter#134693) Test added in flutter#134493 requires an older version of Xcode because default version of Xcode is not compatible with macOS version in CI. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…arks_ios_xcode_debug test (flutter/flutter#134693)
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
flutter/flutter@58ba6c2...72b69f9 2023-09-15 [email protected] Date picker dialog state should dispose members. (flutter/flutter#134804) 2023-09-15 [email protected] Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823) 2023-09-15 [email protected] Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815) 2023-09-15 [email protected] Applied the logo to the Discord badge. (flutter/flutter#134339) 2023-09-15 [email protected] Fix memory leak in ListWheelScrollView (flutter/flutter#134732) 2023-09-15 [email protected] Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784) 2023-09-14 [email protected] Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789) 2023-09-14 [email protected] [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240) 2023-09-14 [email protected] Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778) 2023-09-14 [email protected] Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769) 2023-09-14 [email protected] Allows page removal that contains Localhistoryentry (flutter/flutter#134757) 2023-09-14 [email protected] Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763) 2023-09-14 [email protected] Cover more test/widgets tests with leak tracking flutter#3 (flutter/flutter#134576) 2023-09-14 [email protected] Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755) 2023-09-14 [email protected] Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693) 2023-09-14 [email protected] Cover some Services tests with leak tracing (flutter/flutter#134381) 2023-09-14 [email protected] Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749) 2023-09-14 [email protected] � Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492) 2023-09-14 [email protected] Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719) 2023-09-14 [email protected] Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695) 2023-09-14 [email protected] Added a devicelab test for vulkan validation layers (flutter/flutter#134685) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test added in #134493 requires an older version of Xcode because default version of Xcode is not compatible with macOS version in CI.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.