Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TestClipPaintingContext should dispose ContainerLayer #135949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polina-c merged 17 commits into from
Oct 10, 2023
Merged

TestClipPaintingContext should dispose ContainerLayer #135949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c60c39f
-
polina-c Oct 4, 2023
ebc899f
Merge branch 'master' into RenderEditable
polina-c Oct 4, 2023
42aeda0
Update editable_text_cursor_test.dart
polina-c Oct 4, 2023
3c9ba55
Merge branch 'master' of https://github.com/flutter/flutter into Rend…
polina-c Oct 4, 2023
53caca0
Update mock_canvas.dart
polina-c Oct 4, 2023
9842664
-
polina-c Oct 4, 2023
f3924ed
Merge branch 'master' of https://github.com/flutter/flutter into Rend…
polina-c Oct 4, 2023
76a4871
-
polina-c Oct 4, 2023
9f712fa
Merge branch 'master' of https://github.com/flutter/flutter into Rend…
polina-c Oct 7, 2023
8dfe380
Merge branch 'master' of https://github.com/flutter/flutter into Rend…
polina-c Oct 10, 2023
91c54d6
-
polina-c Oct 10, 2023
f5764d5
Merge branch 'master' of https://github.com/flutter/flutter into Rend…
polina-c Oct 10, 2023
d80923e
-
polina-c Oct 10, 2023
0103010
Update object.dart
polina-c Oct 10, 2023
b4365fc
Merge branch 'master' of https://github.com/flutter/flutter into Rend…
polina-c Oct 10, 2023
0fc3955
Merge branch 'master' into RenderSliverEdgeInsetsPadding
polina-c Oct 10, 2023
e3f7b7d
Merge branch 'RenderSliverEdgeInsetsPadding' of github.com:polina-c/f…
polina-c Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/flutter/test/rendering/rendering_tester.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,11 @@ class FakeTicker implements Ticker {
}

class TestClipPaintingContext extends PaintingContext {
TestClipPaintingContext() : super(ContainerLayer(), Rect.zero);
TestClipPaintingContext() : this._(ContainerLayer());

TestClipPaintingContext._(this._containerLayer) : super(_containerLayer, Rect.zero);

final ContainerLayer _containerLayer;

@override
ClipRectLayer? pushClipRect(
Expand All @@ -397,6 +401,11 @@ class TestClipPaintingContext extends PaintingContext {
}

Clip clipBehavior = Clip.none;

@mustCallSuper
void dispose() {
_containerLayer.dispose();
}
}

class TestPushLayerPaintingContext extends PaintingContext {
Expand Down
20 changes: 4 additions & 16 deletions packages/flutter/test/widgets/grid_view_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,16 +664,8 @@ void main() {
final TestClipPaintingContext context = TestClipPaintingContext();
renderObject.paint(context, Offset.zero);
expect(context.clipBehavior, equals(Clip.none));
},
leakTrackingTestConfig: const LeakTrackingTestConfig(
// TODO(ksokolovskyi): remove after fixing
notDisposedAllowList: <String, int?> {
// https://github.com/flutter/flutter/issues/134575
'OffsetLayer': 1,
// https://github.com/flutter/flutter/issues/134572
'ContainerLayer': 1,
},
));
context.dispose();
});

testWidgetsWithLeakTracking('GridView respects clipBehavior', (WidgetTester tester) async {
await tester.pumpWidget(
Expand Down Expand Up @@ -739,12 +731,8 @@ void main() {
// 4th, check that a non-default clip behavior can be sent to the painting context.
renderObject.paint(context, Offset.zero);
expect(context.clipBehavior, equals(Clip.antiAlias));
},
leakTrackingTestConfig: const LeakTrackingTestConfig(
// TODO(ksokolovskyi): remove after fixing
// https://github.com/flutter/flutter/issues/134572
notDisposedAllowList: <String, int?> {'ContainerLayer': 1},
));
context.dispose();
});

testWidgetsWithLeakTracking('GridView.builder respects clipBehavior', (WidgetTester tester) async {
await tester.pumpWidget(
Expand Down
8 changes: 2 additions & 6 deletions packages/flutter/test/widgets/list_view_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,12 +730,8 @@ void main() {
// 4th, check that a non-default clip behavior can be sent to the painting context.
renderObject.paint(context, Offset.zero);
expect(context.clipBehavior, equals(Clip.antiAlias));
},
leakTrackingTestConfig: const LeakTrackingTestConfig(
// TODO(ksokolovskyi): remove after fixing
// https://github.com/flutter/flutter/issues/134572
notDisposedAllowList: <String, int?> {'ContainerLayer': 1},
));
context.dispose();
});

testWidgetsWithLeakTracking('ListView.builder respects clipBehavior', (WidgetTester tester) async {
await tester.pumpWidget(
Expand Down