Keyboard service doesn't commit the last edit when it's dismissed #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting the proper values, but we thought we were still composing, so the text was still underlined. Fixes flutter#115
| @@ -109,6 +109,7 @@ class _InputState extends State<Input> { | |||
| _editableString.selection.end); | |||
| } else if (!focused && _keyboardHandle.attached) { | |||
| _keyboardHandle.release(); | |||
| _editableString.composing = TextRange.empty; | |||
There was a problem hiding this comment.
So this is the real fix, and the rest is just cleanup to use a single static?
There was a problem hiding this comment.
Yeah, I wanted to write this line of code correctly, which required refactoring how to get an empty text range.
abarth
added a commit
that referenced
this pull request
Jan 25, 2016
Keyboard service doesn't commit the last edit when it's dismissed
TahaTesser
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Aug 13, 2020
* Pause/resume video recording for Android * Specify type * Add pausing and resuming to example app * iOS side of pausing/resuming * More documentation * Version bump * Add video pausing and resuming * get pausing and recording to work for no audio * It works * Formatting * Add test for pausing and resuming * Call success outside try catch block * formatting * Disable audio in test and call result on iOS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting the proper values, but we thought we were still composing, so
the text was still underlined.
Fixes #115