Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove duplicate padding on CupertinoFormSection#137039

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
JaspervanRiet:128419-fix-section-padding
Nov 2, 2023
Merged

Remove duplicate padding on CupertinoFormSection#137039
auto-submit[bot] merged 3 commits into
flutter:masterfrom
JaspervanRiet:128419-fix-section-padding

Conversation

@JaspervanRiet
Copy link
Copy Markdown
Contributor

@JaspervanRiet JaspervanRiet commented Oct 22, 2023 •
edited
Loading

Fixes #128419, removes the duplicate padding that exists around the header and footer on CupertinoFormSection. This PR takes the implementation in #129065 and adds tests. I added the ones suggested in the PR review, as well as one more to test that margin is passed correctly from CupertinoFormSection to CupertinoListSection.

Note: I can't quite figure out if this is also a fix to #121543.

Potential review questions:

  • Is the use of offsetMoreOrLessEquals here correct? I used it because of the vertical positioning. The horizontal positioning is always exact.

Screenshots

Before

image

After

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Oct 22, 2023
MitchellGoodwin
MitchellGoodwin approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some easy linter issues. Thank you for putting these tests together.

For the record, this would not be a fix for #121543. I was originally wrong in thinking they were related, but the paddings in question are in separate places.

Comment thread packages/flutter/test/cupertino/form_section_test.dart Outdated
Comment thread packages/flutter/test/cupertino/list_section_test.dart Outdated
@JaspervanRiet
Copy link
Copy Markdown
Contributor Author

JaspervanRiet commented Nov 2, 2023

@MitchellGoodwin is this ready to merge?

Piinks
Piinks approved these changes Nov 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023
@auto-submit auto-submit Bot merged commit 55eb5e1 into flutter:master Nov 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
2db7d53 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
e1fe45d 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
b25a394 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
da21f43 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
225664e 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
ea26ffd 
…tter#137039)
@JaspervanRiet JaspervanRiet deleted the 128419-fix-section-padding branch November 3, 2023 09:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
4904a06 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
5bb7474 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
5cd1e72 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
815d245 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
c0128e8 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
ed8f80d 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
13330dc 
…tter#137039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
c16efa5 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
0fd37c3 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
f968563 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
46be4b0 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
2e28f64 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
863a7c9 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
08dcea6 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
ffaff78 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
056e849 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
5dde2ee 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
d7fcd19 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
0683ecc 
…tter#137039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
de6fc94 
…tter#137039)
@goderbauer goderbauer mentioned this pull request Nov 21, 2023
Closed
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
55eb5e1 Remove duplicate padding on CupertinoFormSection (flutter/flu…
0a26754 
…tter#137039)
@MitchellGoodwin MitchellGoodwin mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoFormSection header is wrapped by Padding twice, since Flutter 3.7.0

3 participants

@JaspervanRiet @Piinks @MitchellGoodwin